* Re: [PATCH v10 1/3] fs: Add trusted_for(2) syscall implementation and related sysctl
[not found] <20200924153228.387737-2-mic@digikod.net>
@ 2020-09-25 4:46 ` kernel test robot
2020-09-25 9:40 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-09-25 4:46 UTC (permalink / raw)
To: Mickaël Salaün, Al Viro, Andrew Morton, Arnd Bergmann,
James Morris, Jonathan Corbet, Shuah Khan
Cc: kbuild-all, clang-built-linux, Linux Memory Management List,
Mickaël Salaün, Aleksa Sarai, Alexei Starovoitov
[-- Attachment #1: Type: text/plain, Size: 6715 bytes --]
Hi "Mickaël,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on tip/x86/asm kselftest/next linus/master v5.9-rc6 next-20200924]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Micka-l-Sala-n/Add-trusted_for-2-was-O_MAYEXEC/20200924-234005
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: mips-randconfig-r024-20200923 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c32e69b2ce7abfb151a87ba363ac9e25abf7d417)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from fs//autofs/dev-ioctl.c:9:
>> include/linux/syscalls.h:432:46: warning: declaration of 'enum trusted_for_usage' will not be visible outside of this function [-Wvisibility]
asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
^
1 warning generated.
--
In file included from drivers/char/random.c:335:
>> include/linux/syscalls.h:432:46: warning: declaration of 'enum trusted_for_usage' will not be visible outside of this function [-Wvisibility]
asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
^
drivers/char/random.c:2297:6: warning: no previous prototype for function 'add_hwgenerator_randomness' [-Wmissing-prototypes]
void add_hwgenerator_randomness(const char *buffer, size_t count,
^
drivers/char/random.c:2297:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void add_hwgenerator_randomness(const char *buffer, size_t count,
^
static
2 warnings generated.
--
In file included from drivers/android/binder.c:66:
>> include/linux/syscalls.h:432:46: warning: declaration of 'enum trusted_for_usage' will not be visible outside of this function [-Wvisibility]
asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
^
In file included from drivers/android/binder.c:6207:
In file included from drivers/android/binder_trace.h:399:
include/trace/define_trace.h:95:10: fatal error: './binder_trace.h' file not found
#include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/define_trace.h:90:32: note: expanded from macro 'TRACE_INCLUDE'
# define TRACE_INCLUDE(system) __TRACE_INCLUDE(system)
^~~~~~~~~~~~~~~~~~~~~~~
include/trace/define_trace.h:87:34: note: expanded from macro '__TRACE_INCLUDE'
# define __TRACE_INCLUDE(system) __stringify(TRACE_INCLUDE_PATH/system.h)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
#define __stringify(x...) __stringify_1(x)
^~~~~~~~~~~~~~~~
include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
#define __stringify_1(x...) #x
^~
<scratch space>:35:1: note: expanded from here
"./binder_trace.h"
^~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
# https://github.com/0day-ci/linux/commit/4671d1c72b214c586edd9293053dabfa053b003a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Micka-l-Sala-n/Add-trusted_for-2-was-O_MAYEXEC/20200924-234005
git checkout 4671d1c72b214c586edd9293053dabfa053b003a
vim +432 include/linux/syscalls.h
413
414 /* fs/open.c */
415 asmlinkage long sys_statfs(const char __user * path,
416 struct statfs __user *buf);
417 asmlinkage long sys_statfs64(const char __user *path, size_t sz,
418 struct statfs64 __user *buf);
419 asmlinkage long sys_fstatfs(unsigned int fd, struct statfs __user *buf);
420 asmlinkage long sys_fstatfs64(unsigned int fd, size_t sz,
421 struct statfs64 __user *buf);
422 asmlinkage long sys_truncate(const char __user *path, long length);
423 asmlinkage long sys_ftruncate(unsigned int fd, unsigned long length);
424 #if BITS_PER_LONG == 32
425 asmlinkage long sys_truncate64(const char __user *path, loff_t length);
426 asmlinkage long sys_ftruncate64(unsigned int fd, loff_t length);
427 #endif
428 asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len);
429 asmlinkage long sys_faccessat(int dfd, const char __user *filename, int mode);
430 asmlinkage long sys_faccessat2(int dfd, const char __user *filename, int mode,
431 int flags);
> 432 asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
433 asmlinkage long sys_chdir(const char __user *filename);
434 asmlinkage long sys_fchdir(unsigned int fd);
435 asmlinkage long sys_chroot(const char __user *filename);
436 asmlinkage long sys_fchmod(unsigned int fd, umode_t mode);
437 asmlinkage long sys_fchmodat(int dfd, const char __user * filename,
438 umode_t mode);
439 asmlinkage long sys_fchownat(int dfd, const char __user *filename, uid_t user,
440 gid_t group, int flag);
441 asmlinkage long sys_fchown(unsigned int fd, uid_t user, gid_t group);
442 asmlinkage long sys_openat(int dfd, const char __user *filename, int flags,
443 umode_t mode);
444 asmlinkage long sys_openat2(int dfd, const char __user *filename,
445 struct open_how *how, size_t size);
446 asmlinkage long sys_close(unsigned int fd);
447 asmlinkage long sys_close_range(unsigned int fd, unsigned int max_fd,
448 unsigned int flags);
449 asmlinkage long sys_vhangup(void);
450
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42851 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v10 1/3] fs: Add trusted_for(2) syscall implementation and related sysctl
[not found] <20200924153228.387737-2-mic@digikod.net>
2020-09-25 4:46 ` [PATCH v10 1/3] fs: Add trusted_for(2) syscall implementation and related sysctl kernel test robot
@ 2020-09-25 9:40 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-09-25 9:40 UTC (permalink / raw)
To: Mickaël Salaün, Al Viro, Andrew Morton, Arnd Bergmann,
James Morris, Jonathan Corbet, Shuah Khan
Cc: kbuild-all, Linux Memory Management List,
Mickaël Salaün, Aleksa Sarai, Alexei Starovoitov
[-- Attachment #1: Type: text/plain, Size: 12406 bytes --]
Hi "Mickaël,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on tip/x86/asm kselftest/next linus/master v5.9-rc6 next-20200924]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Micka-l-Sala-n/Add-trusted_for-2-was-O_MAYEXEC/20200924-234005
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4671d1c72b214c586edd9293053dabfa053b003a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Micka-l-Sala-n/Add-trusted_for-2-was-O_MAYEXEC/20200924-234005
git checkout 4671d1c72b214c586edd9293053dabfa053b003a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from kernel/fork.c:54:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
kernel/fork.c:160:13: warning: no previous prototype for 'arch_release_task_struct' [-Wmissing-prototypes]
160 | void __weak arch_release_task_struct(struct task_struct *tsk)
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/fork.c:743:20: warning: no previous prototype for 'arch_task_cache_init' [-Wmissing-prototypes]
743 | void __init __weak arch_task_cache_init(void) { }
| ^~~~~~~~~~~~~~~~~~~~
kernel/fork.c:834:12: warning: no previous prototype for 'arch_dup_task_struct' [-Wmissing-prototypes]
834 | int __weak arch_dup_task_struct(struct task_struct *dst,
| ^~~~~~~~~~~~~~~~~~~~
--
In file included from kernel/exec_domain.c:19:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
--
In file included from kernel/exit.c:42:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
kernel/exit.c:1754:13: warning: no previous prototype for 'abort' [-Wmissing-prototypes]
1754 | __weak void abort(void)
| ^~~~~
--
In file included from kernel/signal.c:30:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
kernel/signal.c:4608:6: warning: no previous prototype for 'kdb_send_sig' [-Wmissing-prototypes]
4608 | void kdb_send_sig(struct task_struct *t, int sig)
| ^~~~~~~~~~~~
--
In file included from kernel/module.c:27:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
In file included from kernel/module.c:35:
include/linux/vermagic.h:36:10: fatal error: generated/randomize_layout_hash.h: No such file or directory
36 | #include <generated/randomize_layout_hash.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
--
In file included from kernel/audit.c:44:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
kernel/audit.c:1779:14: warning: no previous prototype for 'audit_serial' [-Wmissing-prototypes]
1779 | unsigned int audit_serial(void)
| ^~~~~~~~~~~~
kernel/audit.c: In function 'audit_log_vformat':
kernel/audit.c:1924:2: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1924 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args);
| ^~~
kernel/audit.c:1933:3: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1933 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args2);
| ^~~
--
In file included from kernel/trace/bpf_trace.c:15:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
In file included from kernel/trace/bpf_trace.h:34,
from kernel/trace/bpf_trace.c:25:
include/trace/define_trace.h:95:42: fatal error: ./bpf_trace.h: No such file or directory
95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
| ^
compilation terminated.
--
In file included from kernel/sched/sched.h:65,
from kernel/sched/core.c:13:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
kernel/sched/core.c:2380:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes]
2380 | void sched_set_stop_task(int cpu, struct task_struct *stop)
| ^~~~~~~~~~~~~~~~~~~
--
In file included from kernel/sched/sched.h:65,
from kernel/sched/rt.c:6:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
kernel/sched/rt.c:668:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
668 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from kernel/time/hrtimer.c:30:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:120:21: warning: initialized field overwritten [-Woverride-init]
120 | [CLOCK_REALTIME] = HRTIMER_BASE_REALTIME,
| ^~~~~~~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:120:21: note: (near initialization for 'hrtimer_clock_to_base_table[0]')
kernel/time/hrtimer.c:121:22: warning: initialized field overwritten [-Woverride-init]
121 | [CLOCK_MONOTONIC] = HRTIMER_BASE_MONOTONIC,
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:121:22: note: (near initialization for 'hrtimer_clock_to_base_table[1]')
kernel/time/hrtimer.c:122:21: warning: initialized field overwritten [-Woverride-init]
122 | [CLOCK_BOOTTIME] = HRTIMER_BASE_BOOTTIME,
| ^~~~~~~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:122:21: note: (near initialization for 'hrtimer_clock_to_base_table[7]')
kernel/time/hrtimer.c:123:17: warning: initialized field overwritten [-Woverride-init]
123 | [CLOCK_TAI] = HRTIMER_BASE_TAI,
| ^~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:123:17: note: (near initialization for 'hrtimer_clock_to_base_table[11]')
--
In file included from kernel/events/core.c:34:
>> include/linux/syscalls.h:432:46: warning: 'enum trusted_for_usage' declared inside parameter list will not be visible outside of this definition or declaration
432 | asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
| ^~~~~~~~~~~~~~~~~
kernel/events/core.c:6506:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
6506 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
| ^~~~~~~~~~~~~~~~~~~~~
..
vim +432 include/linux/syscalls.h
413
414 /* fs/open.c */
415 asmlinkage long sys_statfs(const char __user * path,
416 struct statfs __user *buf);
417 asmlinkage long sys_statfs64(const char __user *path, size_t sz,
418 struct statfs64 __user *buf);
419 asmlinkage long sys_fstatfs(unsigned int fd, struct statfs __user *buf);
420 asmlinkage long sys_fstatfs64(unsigned int fd, size_t sz,
421 struct statfs64 __user *buf);
422 asmlinkage long sys_truncate(const char __user *path, long length);
423 asmlinkage long sys_ftruncate(unsigned int fd, unsigned long length);
424 #if BITS_PER_LONG == 32
425 asmlinkage long sys_truncate64(const char __user *path, loff_t length);
426 asmlinkage long sys_ftruncate64(unsigned int fd, loff_t length);
427 #endif
428 asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len);
429 asmlinkage long sys_faccessat(int dfd, const char __user *filename, int mode);
430 asmlinkage long sys_faccessat2(int dfd, const char __user *filename, int mode,
431 int flags);
> 432 asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
433 asmlinkage long sys_chdir(const char __user *filename);
434 asmlinkage long sys_fchdir(unsigned int fd);
435 asmlinkage long sys_chroot(const char __user *filename);
436 asmlinkage long sys_fchmod(unsigned int fd, umode_t mode);
437 asmlinkage long sys_fchmodat(int dfd, const char __user * filename,
438 umode_t mode);
439 asmlinkage long sys_fchownat(int dfd, const char __user *filename, uid_t user,
440 gid_t group, int flag);
441 asmlinkage long sys_fchown(unsigned int fd, uid_t user, gid_t group);
442 asmlinkage long sys_openat(int dfd, const char __user *filename, int flags,
443 umode_t mode);
444 asmlinkage long sys_openat2(int dfd, const char __user *filename,
445 struct open_how *how, size_t size);
446 asmlinkage long sys_close(unsigned int fd);
447 asmlinkage long sys_close_range(unsigned int fd, unsigned int max_fd,
448 unsigned int flags);
449 asmlinkage long sys_vhangup(void);
450
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67646 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread