From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD094C4727F for ; Tue, 22 Sep 2020 23:17:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 232112223E for ; Tue, 22 Sep 2020 23:17:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="IJcFpl9Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 232112223E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5EB9D6B0003; Tue, 22 Sep 2020 19:17:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59CB26B0055; Tue, 22 Sep 2020 19:17:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1E56B005A; Tue, 22 Sep 2020 19:17:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 344696B0003 for ; Tue, 22 Sep 2020 19:17:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E6307181AEF09 for ; Tue, 22 Sep 2020 23:17:53 +0000 (UTC) X-FDA: 77292262026.02.love12_140789127151 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id BBB7910127FA1 for ; Tue, 22 Sep 2020 23:17:53 +0000 (UTC) X-HE-Tag: love12_140789127151 X-Filterd-Recvd-Size: 4983 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Sep 2020 23:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1600816673; x=1632352673; h=date:from:to:cc:message-id:references:mime-version: in-reply-to:subject; bh=5R3Krtkzle1NhoP1m+0L88WAV6llnORnKP70Telk+cY=; b=IJcFpl9QCXh26T5Vdj8LU31Kqbuf7YD4MU5ly6hdXCNM8ECbpQsJXwoo FJ9MraRYqA5ozZYnIEWY6YPa/OVCefsdYceX/r+zRCHC7fhL+PuMcvMto DC5/8KlrN1IAiOy0wLoQQesqBCuXq4heD/+pD/ar2w1xe8uyaQzVRYfnJ Y=; X-IronPort-AV: E=Sophos;i="5.77,292,1596499200"; d="scan'208";a="55658258" Subject: Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2c-168cbb73.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 22 Sep 2020 23:17:50 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2c-168cbb73.us-west-2.amazon.com (Postfix) with ESMTPS id 84C6DA1C30; Tue, 22 Sep 2020 23:17:48 +0000 (UTC) Received: from EX13D10UWB003.ant.amazon.com (10.43.161.106) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 23:17:36 +0000 Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D10UWB003.ant.amazon.com (10.43.161.106) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 23:17:36 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 23:17:36 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id 81337408C3; Tue, 22 Sep 2020 23:17:36 +0000 (UTC) Date: Tue, 22 Sep 2020 23:17:36 +0000 From: Anchal Agarwal To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , Message-ID: <20200922231736.GA24215@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <9b970e12491107afda0c1d4a6f154b52d90346ac.1598042152.git.anchalag@amazon.com> <4b2bbc8b-7817-271a-4ff0-5ee5df956049@oracle.com> <20200914214754.GA19975@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200915180055.GB19975@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <5f1e4772-7bd9-e6c0-3fe6-eef98bb72bd8@oracle.com> <20200921215447.GA28503@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 22, 2020 at 12:18:05PM -0400, boris.ostrovsky@oracle.com wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On 9/21/20 5:54 PM, Anchal Agarwal wrote: > > Thanks for the above suggestion. You are right I didn't find a way to declare > > a global state either. I just broke the above check in 2 so that once we have > > support for ARM we should be able to remove aarch64 condition easily. Let me > > know if I am missing nay corner cases with this one. > > > > static int xen_pm_notifier(struct notifier_block *notifier, > > unsigned long pm_event, void *unused) > > { > > int ret = NOTIFY_OK; > > if (!xen_hvm_domain() || xen_initial_domain()) > > ret = NOTIFY_BAD; > > if(IS_ENABLED(CONFIG_ARM64) && (pm_event == PM_SUSPEND_PREPARE || pm_event == HIBERNATION_PREPARE)) > > ret = NOTIFY_BAD; > > > > return ret; > > } > > > > This will allow PM suspend to proceed on x86. Right!! Missed it. Also, wrt KASLR stuff, that issue is still seen sometimes but I haven't had bandwidth to dive deep into the issue and fix it. I seem to have lost your email in my inbox hence covering the question here. > > > -boris >