From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DE4C2D0E2 for ; Tue, 22 Sep 2020 18:34:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8D8A820756 for ; Tue, 22 Sep 2020 18:34:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LMBv9gAb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D8A820756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ECE4E6B005A; Tue, 22 Sep 2020 14:34:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E59126B005C; Tue, 22 Sep 2020 14:34:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D45FD6B005D; Tue, 22 Sep 2020 14:34:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id BB19A6B005A for ; Tue, 22 Sep 2020 14:34:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7FCC88249980 for ; Tue, 22 Sep 2020 18:34:50 +0000 (UTC) X-FDA: 77291548740.28.idea94_1200f4b2714f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 5CA136C04 for ; Tue, 22 Sep 2020 18:34:50 +0000 (UTC) X-HE-Tag: idea94_1200f4b2714f X-Filterd-Recvd-Size: 8424 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Sep 2020 18:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600799689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2e2tdhFMlrwW+fXumGUoJr4qesGrHM0WZlHkfuqDvsA=; b=LMBv9gAbBfB2gpIcTlmJMjQo2slAWMfd2YZF8ttHmJioIwRpzsDxhnzcvePG0dBbICPtnX 0xO+lI/QQ6iFoNAWrawMdgEW5PlV3c+yADoABoERMudc+rputrYEkLgGMi1tsIZYHuFf/8 +HwS3N0ue7jqm6F2z8kZiaQRrGrTQyw= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-53-jlhz17gZPP28hGsxf_TgvA-1; Tue, 22 Sep 2020 14:34:42 -0400 X-MC-Unique: jlhz17gZPP28hGsxf_TgvA-1 Received: by mail-qk1-f200.google.com with SMTP id y17so14542150qky.0 for ; Tue, 22 Sep 2020 11:34:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2e2tdhFMlrwW+fXumGUoJr4qesGrHM0WZlHkfuqDvsA=; b=EQEkAz1Bqx2iS7/NkYXRtbNHPs63CW4tUWTsSA+3KFRfLECjQQ/bAUpx3SKYgZr8CJ jnUXYB9/CAD7Y1PqcgphrkR54wpfwbN7nprxxz3i/cj3g7qdZ/ZT6nLtGwEyMm+Z+ztR dGz/zkaGy++cAFDhna4V5kXxyIsKDP7W2/cTRpA3bKaHgPRKHPG5ntd/hRdPcZETJ8+M ndsVVMjIjMixOfKRwe11gNkJBKCggfz5h5xEGsykx4/hJHXDJskhmsxf6rwwETivAcNm v7w0fMW9GV8h9unwBhmHfjEcEOYeCCMIgexTnIbvPWxxGGb2cqY4WDzI1MGiXgyQkw1h KGQw== X-Gm-Message-State: AOAM533hqHF5LWj9unXuE7wV8F+W4A1yDxzwy7IeucWr8LLY+N2CMIum IPGLnZLWDAb0O/p7YFyyjyPplOHYP+TMJ8FVdDB9j1NVRKoYWJTVUdjyou62Cies2CEGpHIcY4+ 7OdyWJXRV4Z8= X-Received: by 2002:ac8:7003:: with SMTP id x3mr1340905qtm.206.1600799681493; Tue, 22 Sep 2020 11:34:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnAgffUvZjfrts3wLzysg5oFbP4RLUg3wVexTDXtde8ji2nEgCqs8IgonDSwF3ckMD2fRUHw== X-Received: by 2002:ac8:7003:: with SMTP id x3mr1340868qtm.206.1600799681190; Tue, 22 Sep 2020 11:34:41 -0700 (PDT) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-11-70-53-122-15.dsl.bell.ca. [70.53.122.15]) by smtp.gmail.com with ESMTPSA id x126sm12083779qkb.101.2020.09.22.11.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 11:34:40 -0700 (PDT) Date: Tue, 22 Sep 2020 14:34:38 -0400 From: Peter Xu To: Oleg Nesterov Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linus Torvalds , Michal Hocko , Kirill Shutemov , Jann Horn , Kirill Tkhai , Hugh Dickins , Leon Romanovsky , Jan Kara , John Hubbard , Christoph Hellwig , Andrew Morton , Jason Gunthorpe , Andrea Arcangeli Subject: Re: [PATCH 4/5] mm: Do early cow for pinned pages during fork() for ptes Message-ID: <20200922183438.GL19098@xz-x1> References: <20200921211744.24758-1-peterx@redhat.com> <20200921212028.25184-1-peterx@redhat.com> <20200922114839.GC11679@redhat.com> <20200922124013.GD11679@redhat.com> <20200922155842.GG19098@xz-x1> <20200922165216.GF11679@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200922165216.GF11679@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 22, 2020 at 06:52:17PM +0200, Oleg Nesterov wrote: > On 09/22, Peter Xu wrote: > > > > On Tue, Sep 22, 2020 at 02:40:14PM +0200, Oleg Nesterov wrote: > > > On 09/22, Oleg Nesterov wrote: > > > > > > > > On 09/21, Peter Xu wrote: > > > > > > > > > > @@ -859,6 +989,25 @@ static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm, > > > > > spin_needbreak(src_ptl) || spin_needbreak(dst_ptl)) > > > > > break; > > > > > } > > > > > + > > > > > + if (unlikely(data.cow_new_page)) { > > > > > + /* > > > > > + * If cow_new_page set, we must be at the 2nd round of > > > > > + * a previous COPY_MM_BREAK_COW. Try to arm the new > > > > > + * page now. Note that in all cases page_break_cow() > > > > > + * will properly release the objects in copy_mm_data. > > > > > + */ > > > > > + WARN_ON_ONCE(copy_ret != COPY_MM_BREAK_COW); > > > > > + if (pte_install_copied_page(dst_mm, new, src_pte, > > > > > + dst_pte, addr, rss, > > > > > + &data)) { > > > > > + /* We installed the pte successfully; move on */ > > > > > + progress++; > > > > > + continue; > > > > > > > > I'm afraid I misread this patch too ;) > > > > > > > > But it seems to me in this case the main loop can really "leak" > > > > COPY_MM_BREAK_COW. Suppose the the next 31 pte's are pte_none() and > > > > need_resched() is true. > > > > > > > > No? > > > > I still think it's a no... > > > > Note that now we'll reset "progress" every time before the do loop, so we'll > > never reach need_resched() (since progress<32) before pte_install_copied_page() > > when needed. > > Yes. But copy_ret is still COPY_MM_BREAK_COW after pte_install_copied_page(). > Now suppose that the next 31 pte's are pte_none(), progress will be incremented > every time. Yes, I think you're right - I'll need to reset that. > > > I explicitly put the pte_install_copied_page() into the loop just... > ... > > > progress = 0; > > > + if (unlikely(copy_ret == COPY_MM_BREAK_COW)) { > > > + /* > > > + * Note that in all cases pte_install_copied_page() > > > + * will properly release the objects in copy_mm_data. > > > + */ > > > + copy_ret = COPY_MM_DONE; > > > + if (pte_install_copied_page(dst_mm, new, src_pte, > > > + dst_pte, addr, rss, > > > + &data)) { > > > + /* We installed the pte successfully; move on */ > > > + progress++; > > > + goto next; > > > > ... to avoid jumps like this because I think it's really tricky. :) > > To me it looks better before the main loop because we know that > data.cow_new_page != NULL is only possible at the 1st iterattion after > restart ;) > > But I agree, this is subjective, please ignore. Thanks. For simplicity, I'll keep the code majorly as is. But I'm still open to change if e.g. someone else still perfers the other way. > However, I still think > it is better to rely on the copy_ret == COPY_MM_BREAK_COW check rather > than data.cow_new_page != NULL. Yes. Logically we should check both, but now as I'm written it as: if (unlikely(data.cow_new_page)) { WARN_ON_ONCE(copy_ret != COPY_MM_BREAK_COW); ... } I think it's even safer because it's actually checking both, but also warn if only cow_new_page is set, which should never happen anyways. Or I can also do it in inverted order if you think better: if (unlikely(copy_ret == COPY_MM_BREAK_COW)) { WARN_ON_ONCE(!data.cow_new_page); ... } > > > > case COPY_MM_SWAP_CONT: > > > if (add_swap_count_continuation(data.entry, GFP_KERNEL) < 0) > > > return -ENOMEM; > > > - break; > > > + copy_ret = COPY_MM_DONE; > > > > Kind of a continuation of the discussion from previous patch - I think we'd > > better reset copy_ret not only for this case, but move it after the switch > > (just in case there'll be new ones). The new BREAK_COW uses goto so it's quite > > special. > > > > > + goto again; > > > > I feel like this could go wrong without the "addr != end" check later, when > > this is the last pte to check. > > How? We know that copy_one_pte() failed and returned COPY_MM_SWAP_CONT > before addr = end. I think you're right, again. :) Thanks, -- Peter Xu