From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C82CC4346D for ; Mon, 21 Sep 2020 08:08:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DF0C72158C for ; Mon, 21 Sep 2020 08:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Qsz7fDdZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF0C72158C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D50590003B; Mon, 21 Sep 2020 04:08:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5379A90003A; Mon, 21 Sep 2020 04:08:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3664C90003B; Mon, 21 Sep 2020 04:08:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id CC46290003D for ; Mon, 21 Sep 2020 04:08:00 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 96EF3824999B for ; Mon, 21 Sep 2020 08:08:00 +0000 (UTC) X-FDA: 77286340320.19.money55_170f33a27143 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 747B41AD1B9 for ; Mon, 21 Sep 2020 08:08:00 +0000 (UTC) X-HE-Tag: money55_170f33a27143 X-Filterd-Recvd-Size: 3565 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Sep 2020 08:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=eYXlp772S5NwgfYwqpisbRltSHIHkEperICR+k7yOF8=; b=Qsz7fDdZj16Ylfx0LNjysSRJbJ fAi9ANPDKXInAqOa9M3xkjOiVe2qYYbG09ikhI5e0k/gm+tO+xm6ng9EW+5Pn0QJ7xsQtGU1H4w3u 9IZlKAO0AYH2dGQNe1vfOwjecRUAtddftwMGeibUq4QkqjCEgq+mhS0U53zk7y5Wwwiy1AVJFipZn 5lUdnZ0Pqu6IdH0kSH9XQ6so8hoe9hByXTsnu3qgunSiaaawVhRt6nyXp4FP34e+os17Su6epEqz7 oZ+x0Wfq0sYJNx7Qs9FvBrnqZPb+RHqy4ElL0cqcyDDrtuNUmkW7b+NLEFnFw7JWUCfiZqYZCbNpN 6i18MBYg==; Received: from p4fdb0c34.dip0.t-ipconnect.de ([79.219.12.52] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKGrB-0006W2-02; Mon, 21 Sep 2020 08:07:30 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Song Liu , Hans de Goede , Coly Li , Richard Weinberger , Minchan Kim , Johannes Thumshirn , Justin Sanders , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Jan Kara , Johannes Thumshirn Subject: [PATCH 02/13] drbd: remove dead code in device_to_statistics Date: Mon, 21 Sep 2020 10:07:23 +0200 Message-Id: <20200921080734.452759-3-hch@lst.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921080734.452759-1-hch@lst.de> References: <20200921080734.452759-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ever since the switch to blk-mq, a lower device not used for VM writeback will not be marked congested, so the check will never trigger. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara Reviewed-by: Johannes Thumshirn --- drivers/block/drbd/drbd_nl.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 43c8ae4d9fca81..aaff5bde391506 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -3370,7 +3370,6 @@ static void device_to_statistics(struct device_stat= istics *s, if (get_ldev(device)) { struct drbd_md *md =3D &device->ldev->md; u64 *history_uuids =3D (u64 *)s->history_uuids; - struct request_queue *q; int n; =20 spin_lock_irq(&md->uuid_lock); @@ -3384,11 +3383,6 @@ static void device_to_statistics(struct device_sta= tistics *s, spin_unlock_irq(&md->uuid_lock); =20 s->dev_disk_flags =3D md->flags; - q =3D bdev_get_queue(device->ldev->backing_bdev); - s->dev_lower_blocked =3D - bdi_congested(q->backing_dev_info, - (1 << WB_async_congested) | - (1 << WB_sync_congested)); put_ldev(device); } s->dev_size =3D drbd_get_capacity(device->this_bdev); --=20 2.28.0