From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA4FC43463 for ; Sat, 19 Sep 2020 06:58:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 46ADA22208 for ; Sat, 19 Sep 2020 06:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46ADA22208 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 93A268E0001; Sat, 19 Sep 2020 02:58:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EA1C6B005D; Sat, 19 Sep 2020 02:58:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FF3E8E0001; Sat, 19 Sep 2020 02:58:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 69B146B005A for ; Sat, 19 Sep 2020 02:58:21 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 25E6B181AEF1D for ; Sat, 19 Sep 2020 06:58:21 +0000 (UTC) X-FDA: 77278907202.28.level98_4d0365627131 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id F1F356C04 for ; Sat, 19 Sep 2020 06:58:20 +0000 (UTC) X-HE-Tag: level98_4d0365627131 X-Filterd-Recvd-Size: 2045 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Sep 2020 06:58:20 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 9D9B768BEB; Sat, 19 Sep 2020 08:58:16 +0200 (CEST) Date: Sat, 19 Sep 2020 08:58:16 +0200 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Johannes Thumshirn Subject: Re: [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE Message-ID: <20200919065816.GA8237@lst.de> References: <20200910144833.742260-1-hch@lst.de> <20200910144833.742260-4-hch@lst.de> <20200917095507.GJ7347@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917095507.GJ7347@quack2.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 17, 2020 at 11:55:07AM +0200, Jan Kara wrote: > On Thu 10-09-20 16:48:23, Christoph Hellwig wrote: > > This case isn't ever used. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Johannes Thumshirn > > Are you sure it's never used? As far as I'm reading drdb code the contents > of the disk_conf structure seems to be received through netlink (that code > is really a macro hell) and so read_balancing attribute passed to > remote_due_to_read_balancing() can have any value userspace passed to it. You are right, looking at how disk_conf is used I can't convince myself that it is indeed not set through netlink and I've thus dropped the patch.