From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD8BBC43463 for ; Sat, 19 Sep 2020 04:20:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E26C2311D for ; Sat, 19 Sep 2020 04:20:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UTpcdDVB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E26C2311D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 32A8A6B0075; Sat, 19 Sep 2020 00:20:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 298646B007B; Sat, 19 Sep 2020 00:20:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15CDA6B0078; Sat, 19 Sep 2020 00:20:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id F3AF46B0074 for ; Sat, 19 Sep 2020 00:20:41 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C20BC248E for ; Sat, 19 Sep 2020 04:20:41 +0000 (UTC) X-FDA: 77278509882.22.voice60_580e4b027130 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 9D0CE18038E60 for ; Sat, 19 Sep 2020 04:20:41 +0000 (UTC) X-HE-Tag: voice60_580e4b027130 X-Filterd-Recvd-Size: 3421 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Sep 2020 04:20:41 +0000 (UTC) Received: from localhost.localdomain (c-71-198-47-131.hsd1.ca.comcast.net [71.198.47.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3ADEE22208; Sat, 19 Sep 2020 04:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600489240; bh=hnDBDm/0gpMNBjiaT6pFzyQCl1gatJgakUiMWgconGQ=; h=Date:From:To:Subject:In-Reply-To:From; b=UTpcdDVBFiLXJAI26xEqv0xdJ5NaoM52QvWY8w1Y05W9eEFD2WyCNv2zTJPaoMaje ZEFIWm2ulBWO4mJ5NeuIYeOskyYF16s/SkaA33OHMnxDrrKxNIUmKhprL5hKKUUSyj fMttAMy63ek8B3GplCANZN7LrbRniXVuksKq0PME= Date: Fri, 18 Sep 2020 21:20:39 -0700 From: Andrew Morton To: akpm@linux-foundation.org, hch@lst.de, jack@suse.cz, linux-mm@kvack.org, mm-commits@vger.kernel.org, tklauser@distanz.ch, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk Subject: [patch 14/15] fs/fs-writeback.c: adjust dirtytime_interval_handler definition to match prototype Message-ID: <20200919042039.taXFWO2ve%akpm@linux-foundation.org> In-Reply-To: <20200918211925.7e97f0ef63d92f5cfe5ccbc5@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tobias Klauser Subject: fs/fs-writeback.c: adjust dirtytime_interval_handler definition to match prototype Commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") changed ctl_table.proc_handler to take a kernel pointer. Adjust the definition of dirtytime_interval_handler to match its prototype in linux/writeback.h which fixes the following sparse error/warning: fs/fs-writeback.c:2189:50: warning: incorrect type in argument 3 (different address spaces) fs/fs-writeback.c:2189:50: expected void * fs/fs-writeback.c:2189:50: got void [noderef] __user *buffer fs/fs-writeback.c:2184:5: error: symbol 'dirtytime_interval_handler' redeclared with different type (incompatible argument 3 (different address spaces)): fs/fs-writeback.c:2184:5: int extern [addressable] [signed] [toplevel] dirtytime_interval_handler( ... ) fs/fs-writeback.c: note: in included file: ./include/linux/writeback.h:374:5: note: previously declared as: ./include/linux/writeback.h:374:5: int extern [addressable] [signed] [toplevel] dirtytime_interval_handler( ... ) Link: https://lkml.kernel.org/r/20200907093140.13434-1-tklauser@distanz.ch Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") Signed-off-by: Tobias Klauser Reviewed-by: Jan Kara Cc: Christoph Hellwig Cc: Al Viro Signed-off-by: Andrew Morton --- fs/fs-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/fs-writeback.c~fs-adjust-dirtytime_interval_handler-definition-to-match-prototype +++ a/fs/fs-writeback.c @@ -2184,7 +2184,7 @@ static int __init start_dirtytime_writeb __initcall(start_dirtytime_writeback); int dirtytime_interval_handler(struct ctl_table *table, int write, - void __user *buffer, size_t *lenp, loff_t *ppos) + void *buffer, size_t *lenp, loff_t *ppos) { int ret; _