From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD69C43466 for ; Fri, 18 Sep 2020 15:29:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1A0B2078B for ; Fri, 18 Sep 2020 15:29:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1A0B2078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 287D76B0037; Fri, 18 Sep 2020 11:29:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23851900002; Fri, 18 Sep 2020 11:29:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14DDD6B005C; Fri, 18 Sep 2020 11:29:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id F2B456B0037 for ; Fri, 18 Sep 2020 11:29:36 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7C1CF180AD81D for ; Fri, 18 Sep 2020 15:29:36 +0000 (UTC) X-FDA: 77276566752.24.feet56_4504a7a2712c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 375CD1A4A7 for ; Fri, 18 Sep 2020 15:29:36 +0000 (UTC) X-HE-Tag: feet56_4504a7a2712c X-Filterd-Recvd-Size: 3495 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 15:29:35 +0000 (UTC) Received: from gaia (unknown [31.124.44.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 559FA2388B; Fri, 18 Sep 2020 15:29:32 +0000 (UTC) Date: Fri, 18 Sep 2020 16:29:29 +0100 From: Catalin Marinas To: Andrey Konovalov Cc: Marco Elver , Dmitry Vyukov , Vincenzo Frascino , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Subject: Re: [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata Message-ID: <20200918152928.GF6335@gaia> References: <20200918144423.GF2384246@elver.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 04:55:45PM +0200, Andrey Konovalov wrote: > On Fri, Sep 18, 2020 at 4:44 PM Marco Elver wrote: > > > > On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote: > > [...] > > > static void set_track(struct kmem_cache *s, void *object, > > > @@ -583,7 +585,8 @@ static void set_track(struct kmem_cache *s, void *object, > > > unsigned int nr_entries; > > > > > > metadata_access_enable(); > > > - nr_entries = stack_trace_save(p->addrs, TRACK_ADDRS_COUNT, 3); > > > + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > > > + TRACK_ADDRS_COUNT, 3); > > > > Suggested edit (below 100 cols): > > > > - nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > > - TRACK_ADDRS_COUNT, 3); > > + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), TRACK_ADDRS_COUNT, 3); > > Ah, yes, it's a 100 lines now :) Will do in v3, thanks! Don't get too carried way ;). The preferred limit is still 80, as per Documentation/process/coding-style.rst (and commit bdc48fa11e46), unless it significantly increases readability and does not hide information. The checkpatch.pl was changed as not to make 80 a hard limit (and so an arbitrary higher limit was picked). What (to me) would increase readability above is aligning the descendants to the open function parenthesis rather than increasing the line length. Anyway, it's up to you on the kasan code, just don't bother changing the patches for longer lines in arch/arm64. -- Catalin