From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E81C43464 for ; Fri, 18 Sep 2020 14:44:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 92BCB21973 for ; Fri, 18 Sep 2020 14:44:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XIp6kndV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92BCB21973 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 19D64900002; Fri, 18 Sep 2020 10:44:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14F4C6B005A; Fri, 18 Sep 2020 10:44:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03E53900002; Fri, 18 Sep 2020 10:44:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id DFA286B0037 for ; Fri, 18 Sep 2020 10:44:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 96118173087F for ; Fri, 18 Sep 2020 14:44:32 +0000 (UTC) X-FDA: 77276453184.30.tent49_2b178cc2712c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 5E17D180B3C85 for ; Fri, 18 Sep 2020 14:44:32 +0000 (UTC) X-HE-Tag: tent49_2b178cc2712c X-Filterd-Recvd-Size: 4237 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 14:44:31 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id s13so5571696wmh.4 for ; Fri, 18 Sep 2020 07:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6NiKzp3GYnVNlrj1nKLgBBFJ1a03bOSILhGt3u/+Pok=; b=XIp6kndVEG2N2+RGvk2CLTkKWfRU+U5aAp7NUBTHXY8UWtgpV3qgnO6RIrKMJP2gtz zirQylm1yKbgnZxlriyNfUVIaDLWf4G84eDl5CnQNKUWfoRInb8kZRK9KDBDK2khyC6j QEQ1CtSCDRHUIXTobBj4jhMHt6V8yVSBE8UcDUqWlt1em7Ef90dKhlzHeN1No1G4zCBl NeM9HvHya5j56QPjDMQhy6xDxEmDoAxKDxIbds8HUqMCsfdg5TZgEpm9xikP/ip6Z32a r+FXgb8s4aCv3lU3KmOPVPxLv4cZXqc05XtlByqTDPNAUqIQrmG6wp2rERCitlLOsLJV kqsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6NiKzp3GYnVNlrj1nKLgBBFJ1a03bOSILhGt3u/+Pok=; b=q85MPPUdlYgOj6PhG/Knq7+gEEIa/i376Zni+qgjXr2RVl/x7QoAr/x4bBli7yk3rN /2BBZufWuUkXzohh3nce57H+AzPexcP4TlNjkzDhZoR8o3uiq4GHRFloOa0/5Htirj67 JaTVC3QVvkkM4tO8BSW1tA2v4k0pa0JjL6eosvwmE5JxuY4ZbnX6F32ju4X88pYImLOc 833+758iuBHEHvsN+DT7fqPsNF4i8ZHa50HMoc7LefaXUkw5FTrH2whaFkKZ4+ESGutS 0aH09T6Y/3YfyadqmutOJDfxGwWWs6TWByIzxbl9xrjM+1/znuvQTSuTmrZZcJvREnE8 +prg== X-Gm-Message-State: AOAM5338MwN22U5tx/tSCgZAIK6y9DdjnaQG9GNsJeyRA6f8yFBVKN35 MpUtBeW5vSE9v32ZsfILNuLJRA== X-Google-Smtp-Source: ABdhPJyFC4mR1SfiLdJTxPUvBtO9C0cNuL9WhIwJnbYCiO8CdCCbWcOJrWJ1D+arshhoBuJ5gPciJQ== X-Received: by 2002:a1c:a953:: with SMTP id s80mr15793418wme.70.1600440270291; Fri, 18 Sep 2020 07:44:30 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id s17sm5860736wrr.40.2020.09.18.07.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 07:44:29 -0700 (PDT) Date: Fri, 18 Sep 2020 16:44:23 +0200 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata Message-ID: <20200918144423.GF2384246@elver.google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.4 (2020-06-18) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote: [...] > static void set_track(struct kmem_cache *s, void *object, > @@ -583,7 +585,8 @@ static void set_track(struct kmem_cache *s, void *object, > unsigned int nr_entries; > > metadata_access_enable(); > - nr_entries = stack_trace_save(p->addrs, TRACK_ADDRS_COUNT, 3); > + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > + TRACK_ADDRS_COUNT, 3); Suggested edit (below 100 cols): - nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), - TRACK_ADDRS_COUNT, 3); + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), TRACK_ADDRS_COUNT, 3);