From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C18C43463 for ; Fri, 18 Sep 2020 13:17:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27C6620848 for ; Fri, 18 Sep 2020 13:17:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27C6620848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B8AE8E0003; Fri, 18 Sep 2020 09:17:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5400E8E0001; Fri, 18 Sep 2020 09:17:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42F988E0003; Fri, 18 Sep 2020 09:17:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 2A04B8E0001 for ; Fri, 18 Sep 2020 09:17:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DD5B12485 for ; Fri, 18 Sep 2020 13:17:05 +0000 (UTC) X-FDA: 77276232810.26.stamp08_5d08ff72712b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id B1C4D1804B660 for ; Fri, 18 Sep 2020 13:17:05 +0000 (UTC) X-HE-Tag: stamp08_5d08ff72712b X-Filterd-Recvd-Size: 5518 Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 13:17:04 +0000 (UTC) Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id EC5B2F2C726B32665062; Fri, 18 Sep 2020 14:17:02 +0100 (IST) Received: from localhost (10.52.125.116) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 18 Sep 2020 14:17:02 +0100 Date: Fri, 18 Sep 2020 14:15:24 +0100 From: Jonathan Cameron To: Jean-Philippe Brucker CC: , , , , , , , , , , , , Subject: Re: [PATCH v10 00/13] iommu: Shared Virtual Addressing for SMMUv3 (PT sharing part) Message-ID: <20200918141524.00004cef@Huawei.com> In-Reply-To: <20200918101852.582559-1-jean-philippe@linaro.org> References: <20200918101852.582559-1-jean-philippe@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.125.116] X-ClientProxiedBy: lhreml741-chm.china.huawei.com (10.201.108.191) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Sep 2020 12:18:40 +0200 Jean-Philippe Brucker wrote: > This is version 10 of the page table sharing support for Arm SMMUv3. > Patch 1 still needs an Ack from mm maintainers. However patches 4-11 do > not depend on it, and could get merged for v5.10 regardless. Hi Jean-Philippe, It's been a rather long time since I last looked at this stuff (about v4 I think!), but I just had a read through this set and they all look good to me. FWIW: Reviewed-by: Jonathan Cameron Thanks, Jonathan > > v10: > * Fix patches 3, 8, 9 and 10 following Eric's review. > > v9 resend: https://lore.kernel.org/linux-iommu/20200817171558.325917-1-jean-philippe@linaro.org/ > * Rebased onto v5.9-rc1. Moved to drivers/iommu/arm/arm-smmu-v3/ as a > result. > > v9: https://lore.kernel.org/linux-iommu/20200723145724.3014766-1-jean-philippe@linaro.org/ > * Moved most of the SVA code to arm-smmu-v3-sva.c. This required moving > struct definitions and macros to arm-smmu-v3.h (patch 7), hence the > new 700 insertions/deletions in the diffstat. > * Updated patches 4 and 8 following review. > * Fixed a bug when replacing a private ASID. > > v8: https://lore.kernel.org/linux-iommu/20200618155125.1548969-1-jean-philippe@linaro.org/ > * Split SVA series into three parts: page table sharing, I/O page > faults, and additional features (DVM, VHE and HTTU). > > Fenghua Yu (1): > mm: Define pasid in mm > > Jean-Philippe Brucker (12): > iommu/ioasid: Add ioasid references > iommu/sva: Add PASID helpers > arm64: mm: Pin down ASIDs for sharing mm with devices > iommu/io-pgtable-arm: Move some definitions to a header > arm64: cpufeature: Export symbol read_sanitised_ftr_reg() > iommu/arm-smmu-v3: Move definitions to a header > iommu/arm-smmu-v3: Share process page tables > iommu/arm-smmu-v3: Seize private ASID > iommu/arm-smmu-v3: Check for SVA features > iommu/arm-smmu-v3: Add SVA device feature > iommu/arm-smmu-v3: Implement iommu_sva_bind/unbind() > iommu/arm-smmu-v3: Hook up ATC invalidation to mm ops > > drivers/iommu/Kconfig | 17 + > drivers/iommu/Makefile | 1 + > drivers/iommu/arm/arm-smmu-v3/Makefile | 5 +- > arch/arm64/include/asm/mmu.h | 3 + > arch/arm64/include/asm/mmu_context.h | 11 +- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 752 +++++++++++++++ > drivers/iommu/io-pgtable-arm.h | 30 + > drivers/iommu/iommu-sva-lib.h | 15 + > include/linux/ioasid.h | 10 +- > include/linux/mm_types.h | 4 + > arch/arm64/kernel/cpufeature.c | 1 + > arch/arm64/mm/context.c | 105 ++- > .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 488 ++++++++++ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 860 ++++-------------- > drivers/iommu/intel/iommu.c | 4 +- > drivers/iommu/intel/svm.c | 6 +- > drivers/iommu/io-pgtable-arm.c | 27 +- > drivers/iommu/ioasid.c | 38 +- > drivers/iommu/iommu-sva-lib.c | 86 ++ > MAINTAINERS | 3 +- > 20 files changed, 1731 insertions(+), 735 deletions(-) > create mode 100644 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > create mode 100644 drivers/iommu/io-pgtable-arm.h > create mode 100644 drivers/iommu/iommu-sva-lib.h > create mode 100644 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > create mode 100644 drivers/iommu/iommu-sva-lib.c >