From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB9CC43463 for ; Fri, 18 Sep 2020 10:47:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E690621D24 for ; Fri, 18 Sep 2020 10:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GCp5nQJs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E690621D24 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 434BD900002; Fri, 18 Sep 2020 06:46:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E3AD8E0001; Fri, 18 Sep 2020 06:46:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F9BE900002; Fri, 18 Sep 2020 06:46:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 1AEB88E0001 for ; Fri, 18 Sep 2020 06:46:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C9BDC180AD81F for ; Fri, 18 Sep 2020 10:46:58 +0000 (UTC) X-FDA: 77275854516.30.jewel00_09114c02712a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id A3E4B180B3C83 for ; Fri, 18 Sep 2020 10:46:58 +0000 (UTC) X-HE-Tag: jewel00_09114c02712a X-Filterd-Recvd-Size: 4952 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 10:46:58 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id z9so5070874wmk.1 for ; Fri, 18 Sep 2020 03:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QHJwfG6F4o4CDJIq3QihHGujfsirLPtmR49z41IlzGM=; b=GCp5nQJsngEU7CqhOSgeVeimfPACWUqBt1LffHhGAhS/1zxnqeAVa4HyswDnKVafjc LcOsFs75LdO+ayoBH4Cqlnez9CdpfLecVbqD3pYkANMG1cMxdHTsby2uZGVXIoeaDEAR UKBLLX5PxKq4MDMK7Pb5LqCTmkDbQq0O+DFCJLod0K9Pgj8Hx0/SeGS/gsZEMYghV8mL WjmHa2CguvnM78D7wz6RaDxOV4leyY4jtiNB4qrTNsermGjvXFBXEZlUaqzuFnsD2BTd 4pZnPDJuKvk409QUo110TgepQoGFwW76wa5Ox2yAPwKlzdhnKEIp74z0oga2K1h4+3w2 yMNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QHJwfG6F4o4CDJIq3QihHGujfsirLPtmR49z41IlzGM=; b=BKFJmoMWVjXMN5ApACZBKFgzPeLm2u/MKZKYdltYWNa97I5nIg6QLXWbxlOmbIvIiO eSDjgjMz6X+UGs5S4o137vFGF70pNy1ljT0f1Gxscd3LKrO7ezdCSdRGY2vklVGP13bc 7AEH53h/7mJ48L08huV+CfoymfzIoUACPyVkoL/cnQ1UTlbeEl03rQ/SCwRRkk55eDKE JegdrR9s8CSrqo38QJAHP3Ln8PkVyE2gs1aBc/5odDx+OTMHWcTLSlxRcDoVtG6YpgJ4 pZzuc7AYfxl0cjJouGeUpkPkasyVcf5DtO5SzazB75CbRUnAR6K8B9TO/4d7oKbJxSvu qaeQ== X-Gm-Message-State: AOAM531xgYqGu8FIAHDgcomjmg+LJVq/+BUoOmVGAD46JWYwxvdxt9+y ae/sMOqEwO3hClfIaardXULXHQ== X-Google-Smtp-Source: ABdhPJyAec62/MhHDgU9436e4r2tCBgX1RyhPIH/sMguzyT2/d+Y8t/P8XtIMeWU0KmORGk45uH90w== X-Received: by 2002:a1c:7e15:: with SMTP id z21mr14738241wmc.21.1600426016909; Fri, 18 Sep 2020 03:46:56 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id u17sm4317615wmm.4.2020.09.18.03.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 03:46:56 -0700 (PDT) Date: Fri, 18 Sep 2020 12:46:50 +0200 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 33/37] kasan, arm64: implement HW_TAGS runtime Message-ID: <20200918104650.GA2384246@elver.google.com> References: <74133d1a57c47cb8fec791dd5d1e6417b0579fc3.1600204505.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74133d1a57c47cb8fec791dd5d1e6417b0579fc3.1600204505.git.andreyknvl@google.com> User-Agent: Mutt/1.14.4 (2020-06-18) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote: [...] > arch/arm64/include/asm/memory.h | 4 +- > arch/arm64/kernel/setup.c | 1 - > include/linux/kasan.h | 6 +-- > include/linux/mm.h | 2 +- > include/linux/page-flags-layout.h | 2 +- > mm/kasan/Makefile | 5 ++ > mm/kasan/common.c | 14 +++--- > mm/kasan/kasan.h | 17 +++++-- > mm/kasan/report_tags_hw.c | 47 +++++++++++++++++++ > mm/kasan/report_tags_sw.c | 2 +- > mm/kasan/shadow.c | 2 +- > mm/kasan/tags_hw.c | 78 +++++++++++++++++++++++++++++++ > mm/kasan/tags_sw.c | 2 +- > 13 files changed, 162 insertions(+), 20 deletions(-) > create mode 100644 mm/kasan/report_tags_hw.c > create mode 100644 mm/kasan/tags_hw.c [...] > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index 77c4c9bad1b8..5985be8af2c6 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -358,7 +358,6 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) > smp_init_cpus(); > smp_build_mpidr_hash(); > > - /* Init percpu seeds for random tags after cpus are set up. */ Why was the comment removed and not updated? > kasan_init_tags(); > > #ifdef CONFIG_ARM64_SW_TTBR0_PAN