From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C249BC433E2 for ; Thu, 17 Sep 2020 09:46:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A96A20838 for ; Thu, 17 Sep 2020 09:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A96A20838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C8D926B0055; Thu, 17 Sep 2020 05:46:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3DC76B005C; Thu, 17 Sep 2020 05:46:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7BC68E0001; Thu, 17 Sep 2020 05:46:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id A32846B0055 for ; Thu, 17 Sep 2020 05:46:17 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6B92F8249980 for ; Thu, 17 Sep 2020 09:46:17 +0000 (UTC) X-FDA: 77272072794.10.beam11_1f17a9927121 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 327EB16A0DE for ; Thu, 17 Sep 2020 09:46:17 +0000 (UTC) X-HE-Tag: beam11_1f17a9927121 X-Filterd-Recvd-Size: 2885 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Sep 2020 09:46:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6D705AFE5; Thu, 17 Sep 2020 09:46:49 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 5E80E1E12E1; Thu, 17 Sep 2020 11:46:15 +0200 (CEST) Date: Thu, 17 Sep 2020 11:46:15 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [PATCH 02/12] drbd: remove dead code in device_to_statistics Message-ID: <20200917094615.GI7347@quack2.suse.cz> References: <20200910144833.742260-1-hch@lst.de> <20200910144833.742260-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910144833.742260-3-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 327EB16A0DE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 10-09-20 16:48:22, Christoph Hellwig wrote: > Ever since the switch to blk-mq, a lower device not used for VM > writeback will not be marked congested, so the check will never > trigger. > > Signed-off-by: Christoph Hellwig Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/block/drbd/drbd_nl.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c > index 43c8ae4d9fca81..aaff5bde391506 100644 > --- a/drivers/block/drbd/drbd_nl.c > +++ b/drivers/block/drbd/drbd_nl.c > @@ -3370,7 +3370,6 @@ static void device_to_statistics(struct device_statistics *s, > if (get_ldev(device)) { > struct drbd_md *md = &device->ldev->md; > u64 *history_uuids = (u64 *)s->history_uuids; > - struct request_queue *q; > int n; > > spin_lock_irq(&md->uuid_lock); > @@ -3384,11 +3383,6 @@ static void device_to_statistics(struct device_statistics *s, > spin_unlock_irq(&md->uuid_lock); > > s->dev_disk_flags = md->flags; > - q = bdev_get_queue(device->ldev->backing_bdev); > - s->dev_lower_blocked = > - bdi_congested(q->backing_dev_info, > - (1 << WB_async_congested) | > - (1 << WB_sync_congested)); > put_ldev(device); > } > s->dev_size = drbd_get_capacity(device->this_bdev); > -- > 2.28.0 > -- Jan Kara SUSE Labs, CR