From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 206DEC433E2 for ; Thu, 17 Sep 2020 00:19:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91F04221F1 for ; Thu, 17 Sep 2020 00:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="rBlJl3SX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91F04221F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B5999900022; Wed, 16 Sep 2020 20:19:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B099B90001E; Wed, 16 Sep 2020 20:19:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A203D900022; Wed, 16 Sep 2020 20:19:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 8B17290001E for ; Wed, 16 Sep 2020 20:19:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5335E2C84 for ; Thu, 17 Sep 2020 00:19:38 +0000 (UTC) X-FDA: 77270644836.25.arch00_600cd4f2711e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 1C3031804E3A0 for ; Thu, 17 Sep 2020 00:19:38 +0000 (UTC) X-HE-Tag: arch00_600cd4f2711e X-Filterd-Recvd-Size: 4027 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Sep 2020 00:19:37 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id r9so485562ybd.20 for ; Wed, 16 Sep 2020 17:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=+spLOPOqYEotDF2y8HQ3qi+ewoKqTD1Kc3/rTara360=; b=rBlJl3SXnzuNoP+/CYZPQ99ocjRmNYgBHzsNpUqS8tRmaaXkNFDiL8LiZkJBnSc30D ioYHkZlYVPY2/ZInNiot7dvrlDcK6d0op2AsjfEpJ1lG8kFPPNlbChiO6bJCoH9yX5eK CSmbESZRmWOWBptKgdealJtke9nzCfijbmzNCBloGxf0DvWqSNXu3kvJOX+nJTZewouf pRIwTYr5fCL6fKb7E1Ihb7KqNI+693GnUB0WSFOELf8v7gUyuA7T2sDr5Vyr6IKjL//S oH3VauqBHT252EEw17MgWJ7+0NgX7CtfubK5CrN1kMfxoCqXD1SCT2j9Ubn9c6Wdx4Aq iCqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=+spLOPOqYEotDF2y8HQ3qi+ewoKqTD1Kc3/rTara360=; b=dytKtX1ffogEZDKNTZGS39k/gqSUK2ETLZDnIonrqbvjEXraovZIZuHYcfqG8Xsooc kMxuZKb5qpKGB2iNFW4ieLqVEzHrKiyghRZYwGpGn4yvPRllNiUFAmLQ/Ek3fItahmmK s6eTBCuItQQLAaGQUVzvJFWJJT96xuu9m2PPWu495kGibDVtaCr+8NmHSehi+7rSe/zF GqgvCIB7JtrYDwWnkIlDODX4IBbRSBqE2qhSwiJFaH+bRYvBlO/Djhi7ncJ1EZQd69D5 1S1ZoNMfNAr8hYckO3o1fOQ4+9pq3JiswVRn5ix11vMztdQG0/9xGWW/IaITg4V3vffv WEmA== X-Gm-Message-State: AOAM532jVUeNLXd7jpaYyzi+MZgudAY6jAhinQLniI9ltJMHFcpSfryN 8txs1lv2gwHW8MPL2jWQEnh2w1EH2ysG9qeeXz0= X-Google-Smtp-Source: ABdhPJxFVnDgO0PkN03oaF3DVPp+VMqT0IyJLbNA+PK8/KYsKl3bGJWlYL1KXXFbTUY7SGKtrGdQb6+kqu0h9o/uKi4= X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:f693:9fff:fef4:4d25]) (user=ndesaulniers job=sendgmr) by 2002:a25:d90c:: with SMTP id q12mr5406595ybg.442.1600301976708; Wed, 16 Sep 2020 17:19:36 -0700 (PDT) Date: Wed, 16 Sep 2020 17:19:34 -0700 In-Reply-To: <20200916085933.25220-1-song.bao.hua@hisilicon.com> Message-Id: <20200917001934.2793370-1-ndesaulniers@google.com> Mime-Version: 1.0 References: <20200916085933.25220-1-song.bao.hua@hisilicon.com> X-Mailer: git-send-email 2.28.0.618.gf4bc123cb7-goog Subject: Re: arm64: mm: move dma_contiguous_reserve() to be after paging_init() From: Nick Desaulniers To: song.bao.hua@hisilicon.com Cc: akpm@linux-foundation.org, guro@fb.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linuxarm@huawei.com, mike.kravetz@oracle.com, sfr@canb.auug.org.au, will@kernel.org, ardb@kernel.org, clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1C3031804E3A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It looks like that change referenced may also break arm32 boots with today's next? The following allows me to boot, but I have no idea if it's incorrect or not. diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 45f9d5ec2360..7118b98c1f5f 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -226,9 +226,6 @@ void __init arm_memblock_init(const struct machine_desc *mdesc) early_init_fdt_reserve_self(); early_init_fdt_scan_reserved_mem(); - /* reserve memory for DMA contiguous allocations */ - dma_contiguous_reserve(arm_dma_limit); - arm_memblock_steal_permitted = false; memblock_dump_all(); } @@ -248,6 +245,9 @@ void __init bootmem_init(void) */ sparse_init(); + /* reserve memory for DMA contiguous allocations */ + dma_contiguous_reserve(arm_dma_limit); + /* * Now free the memory - free_area_init needs * the sparse mem_map arrays initialized by sparse_init()