From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C980CC433E2 for ; Wed, 16 Sep 2020 17:58:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22B132074B for ; Wed, 16 Sep 2020 17:58:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22B132074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ruivo.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6168D6B005D; Wed, 16 Sep 2020 13:58:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C7E76B0062; Wed, 16 Sep 2020 13:58:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DE5B6B0068; Wed, 16 Sep 2020 13:58:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 365476B005D for ; Wed, 16 Sep 2020 13:58:37 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E654A180AD807 for ; Wed, 16 Sep 2020 17:58:36 +0000 (UTC) X-FDA: 77269684632.24.clock47_25167272711b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id BA85C1A4A0 for ; Wed, 16 Sep 2020 17:58:36 +0000 (UTC) X-HE-Tag: clock47_25167272711b X-Filterd-Recvd-Size: 2348 Received: from lobo.ruivo.org (lobo.ruivo.org [173.14.175.98]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 17:58:36 +0000 (UTC) Received: by lobo.ruivo.org (Postfix, from userid 1011) id 732CD5335D; Wed, 16 Sep 2020 13:58:35 -0400 (EDT) Received: from jake.ruivo.org (bob.qemu.ruivo [192.168.72.19]) by lobo.ruivo.org (Postfix) with ESMTPA id 33C0752DA4; Wed, 16 Sep 2020 13:58:14 -0400 (EDT) Received: by jake.ruivo.org (Postfix, from userid 1000) id 06FC71A1A61; Wed, 16 Sep 2020 13:58:14 -0400 (EDT) Date: Wed, 16 Sep 2020 13:58:14 -0400 From: Aristeu Rozanski To: osalvador@suse.de Cc: naoya.horiguchi@nec.com, akpm@linux-foundation.org, mhocko@kernel.org, tony.luck@intel.com, cai@lca.pw, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/5] HWpoison: further fixes and cleanups Message-ID: <20200916175813.GD17169@cathedrallabs.org> References: <20200914101559.17103-1-osalvador@suse.de> <20200915212222.GA18315@cathedrallabs.org> <20200916072658.GA10692@linux> <20200916135358.GB17169@cathedrallabs.org> <20200916140921.GA17949@linux> <20200916144603.GC17169@cathedrallabs.org> <9bd7ac81968a7897474804d53bfc1286@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: BA85C1A4A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000401, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 16, 2020 at 06:34:52PM +0200, osalvador@suse.de wrote: > Fat fingers, sorry: > > Ok, this is something different. > The race you saw previously is kinda normal as there is a race window > between spotting a freepage and taking it off the buddy freelists. > The retry patch should help there. > > The issue you are seeing right here is due to the call to > page_handle_poison in __soft_offline_page being wrong, as we pass > hugepage_or_freepage = true inconditionally, which is wrong. > I think it was caused during rebasing. > > Should be: Tests passed with this patch on top of others. Thanks! -- Aristeu