From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7031C433E2 for ; Wed, 16 Sep 2020 15:53:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D34222453 for ; Wed, 16 Sep 2020 15:53:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="VPsY5b+9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D34222453 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 405886B0068; Wed, 16 Sep 2020 11:53:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B5FD6B006C; Wed, 16 Sep 2020 11:53:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CCE66B006E; Wed, 16 Sep 2020 11:53:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 1577C6B0068 for ; Wed, 16 Sep 2020 11:53:46 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CAB8F1F1A for ; Wed, 16 Sep 2020 15:53:45 +0000 (UTC) X-FDA: 77269370010.13.point96_5a126bf2711b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 402D518140B75 for ; Wed, 16 Sep 2020 15:53:45 +0000 (UTC) X-HE-Tag: point96_5a126bf2711b X-Filterd-Recvd-Size: 4422 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 15:53:42 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id z2so6453378qtv.12 for ; Wed, 16 Sep 2020 08:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JKhe+x24T6aRlinfU1OA0YJp748Od2iTkbFGOD/adP4=; b=VPsY5b+9cBMrPc5OVqe2Sukv9mJpEEdjQcog7p8tnhq7DIKhF2vXz0NBYD/FxekDRk 0MMYvfp++wy7O7pKuIBYRP0McSqCeq8ZLcE0WhjTP/TLFLVlaSfDbcFPVH1HKm7GJpmi bhTHll/yTesRo2CU+/S4Vpxo6sxSiuCS3opXM8UdAJFiDisRzMS12UPNu65FH2zOp1Wo w3WuY6QMxp6N1roV1iUPkPZrWLecfNR+ZgQ8j278TZcPetmM3LZWVLKFncsEhKBiATbu MdmOJMmHWYhqTT5JnepiUyrjYGVYcdUVA6gx/AYSBIu8hB4DE4aqzQ1abW3B6o2BdhAc KUtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JKhe+x24T6aRlinfU1OA0YJp748Od2iTkbFGOD/adP4=; b=MrDrpOr8yPcsK224NqFUps5r8kRNMUnhO543fiqOIFMPtAkbMtxffbmt2n825Q6dKO krjjG/TQf7pB7+2O9No1+g2P5QB04oWS0Dw2ImOW3QzQzdGDUUzkPxZy0q/n5/7uasrn OmsSmFy3B/x1p5MjO/fLCCT1begCcQ/DfABuUt8YSv2qu9EIJyvws4tvT9wzt3UlBE2K gLhNN7enxcwx4JrH5gLMNKdTFsO9CQSajIaRRdPm8v23LfyF8ntNSeSDrzMpKO2iQ8q2 CUwLA34iObTMwRttFLZWTBDPe33l6si+MB4NCj2UztL/+1ReOilZXAfW3SnZGsSDMo+t JHRg== X-Gm-Message-State: AOAM530g49etl17BkmNRXv8UB5wgsx+B61cVTGLjmo33vOJJLaEifqlP cmZJBAvL//qbO43eI3gGuhi6nA== X-Google-Smtp-Source: ABdhPJx2dITGjim1Zho+eZRSQ72X3Tuvd292MmMJHtDwXkRhpVS/0/Nt+nrvFxykZ692cQSKX1VL3A== X-Received: by 2002:ac8:fa4:: with SMTP id b33mr24660950qtk.13.1600271621322; Wed, 16 Sep 2020 08:53:41 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id q19sm1570312qtk.74.2020.09.16.08.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 08:53:40 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kIZkZ-0004BL-W7; Wed, 16 Sep 2020 12:53:40 -0300 Date: Wed, 16 Sep 2020 12:53:39 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: remove mmu_notifier_get Message-ID: <20200916155339.GB8409@ziepe.ca> References: <20200916112724.2174759-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916112724.2174759-1-hch@lst.de> X-Rspamd-Queue-Id: 402D518140B75 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 16, 2020 at 01:27:24PM +0200, Christoph Hellwig wrote: > Remove the unused mmu_notifier_get inline function. > > Signed-off-by: Christoph Hellwig > include/linux/mmu_notifier.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h > index b8200782dedeb9..acd1cc41f25d81 100644 > +++ b/include/linux/mmu_notifier.h > @@ -279,16 +279,6 @@ static inline int mm_has_notifiers(struct mm_struct *mm) > > struct mmu_notifier *mmu_notifier_get_locked(const struct mmu_notifier_ops *ops, > struct mm_struct *mm); > -static inline struct mmu_notifier * > -mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm) > -{ > - struct mmu_notifier *ret; > - > - mmap_write_lock(mm); > - ret = mmu_notifier_get_locked(ops, mm); > - mmap_write_unlock(mm); > - return ret; > -} > void mmu_notifier_put(struct mmu_notifier *subscription); > void mmu_notifier_synchronize(void); Looks like I missed this from Fixes: f25a546e6529 ("RDMA/odp: Use mmu_interval_notifier_insert()") Though, I have a vauge recollection that some SVA IOMMU patches posted wanted to use this too? They can bring it back if it makes sense Looks like David is right about the comment, but aside from that: Reviewed-by: Jason Gunthorpe v2 should go through Andrew's tree Thanks, Jason