From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 677DEC43461 for ; Wed, 16 Sep 2020 14:42:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 81AC52224D for ; Wed, 16 Sep 2020 14:42:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="x3fuQca0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81AC52224D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D7B6E6B006C; Wed, 16 Sep 2020 10:42:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D24E4900002; Wed, 16 Sep 2020 10:42:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7D6C6B0070; Wed, 16 Sep 2020 10:42:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 90C956B006C for ; Wed, 16 Sep 2020 10:42:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 559A0349B for ; Wed, 16 Sep 2020 14:42:25 +0000 (UTC) X-FDA: 77269190250.02.cow59_4d149c22711a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 1CC85100B72AC for ; Wed, 16 Sep 2020 14:42:25 +0000 (UTC) X-HE-Tag: cow59_4d149c22711a X-Filterd-Recvd-Size: 5232 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 14:42:23 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id o5so8311710qke.12 for ; Wed, 16 Sep 2020 07:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fKYfJDr6XxN79fp7RRW8vHbFzGf8aLsEG/U2ZaiDjdE=; b=x3fuQca0YO4vXhnbqTr/awp8cN0ZmiMYzYQ/wBG5yKnOrO8F+Nw+YZ0TuosHxJH//Y 3iNLZoxNj3tgOeuQOZc/gGlF2FUljYQwnGuXvAJLuhARwn22qD/0LFjmb/NZ3tKLJ+of Gr1QMEfApz/Dx/Qro6daJdCGB5v8rMY7CZQp0JFUZHnZysVsMBjlc53pAUpu1lkR/jwA GaWH31lJFMfcLnxfjTsd2oFBxFLjxEuT2GZiX3v9V95vS6x+6VnHOOh1j46dEpnz3rOI gItFy9wcDwGEuqN9UCktG0P2Nk87Swobyq2yLNj8GLYSO0YGumg8dOshimjHMZL5xP8Q s4WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fKYfJDr6XxN79fp7RRW8vHbFzGf8aLsEG/U2ZaiDjdE=; b=LWcrp8ejlB56qC+YP+oWTYwUaQsjPhq2IyrGqbh+vDRD411N72v0peMBvO7l2ROIrD UslOTPYPxR0hYqDSaZJaCUIKh+r5wuV3R5esv7a+DPh0oUTVPd4uOFWhN9UL5hIAE0z9 sVFjIQKYFvzvJcempTZFzXgC5Gg4WZFFsS9mbQTD0yWnOcXTFfD5aDDhH3LvZLcK+vXD 29AoiZTKdWtjUVyDGos41kjTrNrG9DxXgcBqHYETDxBhiziDzNOgNqTnaeDYqOjm925Z CcC+eBVHG9qs6xJxgOGzjuLon1sDK3NWOLPjP+mmuun6noDQ9ck39duO6Euilw1Eh5Tp Cnsw== X-Gm-Message-State: AOAM530i6wGAMKL55tEBcsrC/PbuVgWg4pNV1Zh4Q+GqFpy9JII/uayM 8+VYm//pNApDt265eP3wjb/2HQ== X-Google-Smtp-Source: ABdhPJwijrABVKYt/qN7UOpgp0u84imCjvrxLSbBsmEHE10f61LGvpcUBadv1NkypK+pBVqu+G4IGA== X-Received: by 2002:ae9:dd01:: with SMTP id r1mr22802872qkf.467.1600267342448; Wed, 16 Sep 2020 07:42:22 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:445c]) by smtp.gmail.com with ESMTPSA id 16sm19950302qks.102.2020.09.16.07.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 07:42:21 -0700 (PDT) Date: Wed, 16 Sep 2020 10:40:57 -0400 From: Johannes Weiner To: Muchun Song Cc: Tejun Heo , Zefan Li , Jonathan Corbet , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Randy Dunlap , Cgroups , linux-doc@vger.kernel.org, LKML , Linux Memory Management List Subject: Re: [External] Re: [PATCH v5] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 Message-ID: <20200916144057.GA194430@cmpxchg.org> References: <20200915171801.39761-1-songmuchun@bytedance.com> <20200915214845.GB189808@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1CC85100B72AC X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 16, 2020 at 12:14:49PM +0800, Muchun Song wrote: > On Wed, Sep 16, 2020 at 5:50 AM Johannes Weiner wrote: > > > > On Wed, Sep 16, 2020 at 01:18:01AM +0800, Muchun Song wrote: > > > In the cgroup v1, we have a numa_stat interface. This is useful for > > > providing visibility into the numa locality information within an > > > memcg since the pages are allowed to be allocated from any physical > > > node. One of the use cases is evaluating application performance by > > > combining this information with the application's CPU allocation. > > > But the cgroup v2 does not. So this patch adds the missing information. > > > > > > Signed-off-by: Muchun Song > > > Suggested-by: Shakeel Butt > > > Reviewed-by: Shakeel Butt > > > > Yup, that would be useful information to have. Just a few comments on > > the patch below: > > > > > @@ -1368,6 +1368,78 @@ PAGE_SIZE multiple when read back. > > > collapsing an existing range of pages. This counter is not > > > present when CONFIG_TRANSPARENT_HUGEPAGE is not set. > > > > > > + memory.numa_stat > > > + A read-only flat-keyed file which exists on non-root cgroups. > > > > It's a nested key file, not flat. > > This is just copied from memory.stat documentation.Is the memory.stat > also a nested key file? No, memory.stat is a different format. From higher up in the document: Flat keyed KEY0 VAL0\n KEY1 VAL1\n ... Nested keyed KEY0 SUB_KEY0=VAL00 SUB_KEY1=VAL01... KEY1 SUB_KEY0=VAL10 SUB_KEY1=VAL11... ... > > Otherwise, this looks reasonable to me. > > OK. Will do that. Thanks!