From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C50C43461 for ; Wed, 16 Sep 2020 13:13:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1711F2225F for ; Wed, 16 Sep 2020 13:13:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1711F2225F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 81C9E6B0037; Wed, 16 Sep 2020 09:13:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CBEA6B0055; Wed, 16 Sep 2020 09:13:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70A256B005C; Wed, 16 Sep 2020 09:13:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 59E526B0037 for ; Wed, 16 Sep 2020 09:13:56 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0FEB91F1A for ; Wed, 16 Sep 2020 13:13:56 +0000 (UTC) X-FDA: 77268967272.25.wrist58_2f0aa252711a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id CD9C41804E3A1 for ; Wed, 16 Sep 2020 13:13:55 +0000 (UTC) X-HE-Tag: wrist58_2f0aa252711a X-Filterd-Recvd-Size: 3367 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 13:13:53 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0U97kdD0_1600262028; Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0U97kdD0_1600262028) by smtp.aliyun-inc.com(127.0.0.1); Wed, 16 Sep 2020 21:13:48 +0800 Date: Wed, 16 Sep 2020 21:13:48 +0800 From: Wei Yang To: "tiantao (H)" Cc: Wei Yang , Tian Tao , akpm@linux-foundation.org, christian@brauner.io, linux-mm@kvack.org, linuxarm@huawei.com Subject: Re: [PATCH] mm/madvise.c: Remove the unused include statements Message-ID: <20200916131348.GA48496@L-31X9LVDL-1304.local> Reply-To: Wei Yang References: <1599823111-51431-1-git-send-email-tiantao6@hisilicon.com> <20200916125956.GA48267@L-31X9LVDL-1304.local> <43fd7997-9a1d-1baf-943b-4e4320d94339@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <43fd7997-9a1d-1baf-943b-4e4320d94339@huawei.com> X-Rspamd-Queue-Id: CD9C41804E3A1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 16, 2020 at 09:05:34PM +0800, tiantao (H) wrote: > >#include >#include >#include >#include >#include >#include >#include >#include >#include >#include >#include >#include >#include <--------- >#include >#include >#include >#include >#include >#include >#include >#include >#include >#include >#include >#include <--------- > >git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > >you can see the linux/sched/mm.h is included more than once > Ok, I may not have the same tree as yours. > >=E5=9C=A8 2020/9/16 20:59, Wei Yang =E5=86=99=E9=81=93: >> On Fri, Sep 11, 2020 at 07:18:31PM +0800, Tian Tao wrote: >> > linux/sched/mm.h is included more than once, Remove the one that isn= 't >> > necessary. >> >=20 >>=20 >> Would you mind giving more detail about this re-include? I don't see t= he file >> linux/sched/mm.h is included for more than once. >>=20 >> > Signed-off-by: Tian Tao >> > --- >> > mm/madvise.c | 1 - >> > 1 file changed, 1 deletion(-) >> >=20 >> > diff --git a/mm/madvise.c b/mm/madvise.c >> > index c5acc2b..8c175f9 100644 >> > --- a/mm/madvise.c >> > +++ b/mm/madvise.c >> > @@ -30,7 +30,6 @@ >> > #include >> > #include >> > #include >> > -#include >> >=20 >> > #include >> >=20 >> > --=20 >> > 2.7.4 >>=20 --=20 Wei Yang Help you, Help me