Re: [PATCH] mm/madvise.c: Remove the unused include statements

[Wei Yang <richard.weiyang@linux.alibaba.com>]

On Wed, Sep 16, 2020 at 09:05:34PM +0800, tiantao (H) wrote:
>
>#include <linux/mman.h>
>#include <linux/compat.h>
>#include <linux/pagemap.h>
>#include <linux/syscalls.h>
>#include <linux/mempolicy.h>
>#include <linux/page-isolation.h>
>#include <linux/page_idle.h>
>#include <linux/userfaultfd_k.h>
>#include <linux/hugetlb.h>
>#include <linux/falloc.h>
>#include <linux/fadvise.h>
>#include <linux/sched.h>
>#include <linux/sched/mm.h> <---------
>#include <linux/uio.h>
>#include <linux/ksm.h>
>#include <linux/fs.h>
>#include <linux/file.h>
>#include <linux/blkdev.h>
>#include <linux/backing-dev.h>
>#include <linux/pagewalk.h>
>#include <linux/swap.h>
>#include <linux/swapops.h>
>#include <linux/shmem_fs.h>
>#include <linux/mmu_notifier.h>
>#include <linux/sched/mm.h> <---------
>
>git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>
>you can see the linux/sched/mm.h is included more than once
>

Ok, I may not have the same tree as yours.

>
>在 2020/9/16 20:59, Wei Yang 写道:
>> On Fri, Sep 11, 2020 at 07:18:31PM +0800, Tian Tao wrote:
>> > linux/sched/mm.h is included more than once, Remove the one that isn't
>> > necessary.
>> > 
>> 
>> Would you mind giving more detail about this re-include? I don't see the file
>> linux/sched/mm.h is included for more than once.
>> 
>> > Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>> > ---
>> > mm/madvise.c | 1 -
>> > 1 file changed, 1 deletion(-)
>> > 
>> > diff --git a/mm/madvise.c b/mm/madvise.c
>> > index c5acc2b..8c175f9 100644
>> > --- a/mm/madvise.c
>> > +++ b/mm/madvise.c
>> > @@ -30,7 +30,6 @@
>> > #include <linux/swapops.h>
>> > #include <linux/shmem_fs.h>
>> > #include <linux/mmu_notifier.h>
>> > -#include <linux/sched/mm.h>
>> > 
>> > #include <asm/tlb.h>
>> > 
>> > -- 
>> > 2.7.4
>> 

-- 
Wei Yang
Help you, Help me