From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E51C43461 for ; Wed, 16 Sep 2020 12:40:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0703122241 for ; Wed, 16 Sep 2020 12:40:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0703122241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 342EE6B0003; Wed, 16 Sep 2020 08:40:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CD236B0037; Wed, 16 Sep 2020 08:40:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1947B6B0055; Wed, 16 Sep 2020 08:40:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 004136B0003 for ; Wed, 16 Sep 2020 08:40:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B4F7B1DF2 for ; Wed, 16 Sep 2020 12:40:55 +0000 (UTC) X-FDA: 77268884070.03.toes61_2e07c032711a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 8736C28A4EB for ; Wed, 16 Sep 2020 12:40:55 +0000 (UTC) X-HE-Tag: toes61_2e07c032711a X-Filterd-Recvd-Size: 3375 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 12:40:54 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0U97e8cp_1600260047; Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0U97e8cp_1600260047) by smtp.aliyun-inc.com(127.0.0.1); Wed, 16 Sep 2020 20:40:48 +0800 Date: Wed, 16 Sep 2020 20:40:47 +0800 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-s390@vger.kernel.org, Andrew Morton , Michal Hocko , Dan Williams , Jason Gunthorpe , Kees Cook , Ard Biesheuvel , Pankaj Gupta , Baoquan He Subject: Re: [PATCH] kernel/resource: make iomem_resource implicit in release_mem_region_adjustable() Message-ID: <20200916124047.GA47042@L-31X9LVDL-1304.local> Reply-To: Wei Yang References: <20200911103459.10306-1-david@redhat.com> <20200916073041.10355-1-david@redhat.com> <20200916100223.GA46154@L-31X9LVDL-1304.local> <20200916121051.GA46809@L-31X9LVDL-1304.local> <0ee45d30-daa4-190a-2932-fb710d9496db@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ee45d30-daa4-190a-2932-fb710d9496db@redhat.com> X-Rspamd-Queue-Id: 8736C28A4EB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 16, 2020 at 02:16:25PM +0200, David Hildenbrand wrote: >On 16.09.20 14:10, Wei Yang wrote: >> On Wed, Sep 16, 2020 at 12:03:20PM +0200, David Hildenbrand wrote: >>> On 16.09.20 12:02, Wei Yang wrote: >>>> On Wed, Sep 16, 2020 at 09:30:41AM +0200, David Hildenbrand wrote: >>>>> "mem" in the name already indicates the root, similar to >>>>> release_mem_region() and devm_request_mem_region(). Make it implicit. >>>>> The only single caller always passes iomem_resource, other parents are >>>>> not applicable. >>>>> >>>> >>>> Looks good to me. >>>> >>>> Reviewed-by: Wei Yang >>>> >>> >>> Thanks for the review! >>> >> >> Would you send another version? I didn't take a look into the following >> patches, since the 4th is missed. > >Not planning to send another one as long as there are no further >comments. Seems to be an issue on your side because all patches arrived >on linux-mm (see >https://lore.kernel.org/linux-mm/20200911103459.10306-1-david@redhat.com/) > >You can find patch #4 at >https://lore.kernel.org/linux-mm/20200911103459.10306-5-david@redhat.com/ > >(which has CC "Wei Yang ") > Ok, I managed to apply 4th patch manually... >-- >Thanks, > >David / dhildenb -- Wei Yang Help you, Help me