From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45CAC433E2 for ; Wed, 16 Sep 2020 05:21:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F3AFA221E5 for ; Wed, 16 Sep 2020 05:21:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="s70emVkA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3AFA221E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E9FD36B0003; Wed, 16 Sep 2020 01:21:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E50136B0037; Wed, 16 Sep 2020 01:21:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D66B86B0055; Wed, 16 Sep 2020 01:21:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id C14F56B0003 for ; Wed, 16 Sep 2020 01:21:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 61AED8249980 for ; Wed, 16 Sep 2020 05:21:34 +0000 (UTC) X-FDA: 77267776908.01.basin98_130513a27117 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 319C51004BA82 for ; Wed, 16 Sep 2020 05:21:34 +0000 (UTC) X-HE-Tag: basin98_130513a27117 X-Filterd-Recvd-Size: 2666 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 05:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8Hrrl2YETgQJ18Mz1U8xxlDYud6hDQ7zBp3JCuVggPw=; b=s70emVkAQH2kuz+hYMjOjppFaz F1vOeln/Wbn46zef2EvyFVo0mjopnkBIJf4sTbbD5nQJRC5gIlKsTkwjclVWi19c79juGkVg3WgA0 kfRdab9r/L47O1QWDwhi43xUL5G4+Vhff+QXP0gbHov+VFRRRfC9aYO9H3rhk5KFDbxr5TOqsmObu /vL8K8EhuRdSsepWbdmDb2QkXL9oiEAF7kGbFuzbNf/Wbn1B/7wMPUUORpX735qvLTxpReZ5JLW/D PsTKTwiixhsUDdFH1Kdh6h1myAdLtk2FtcXnn/BAJPr3E84RxyjY9y3Dym9mRnAIf+F7+K36dZJMX wg5EC0/g==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIPsk-0003YW-VP; Wed, 16 Sep 2020 05:21:27 +0000 Date: Wed, 16 Sep 2020 06:21:26 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, Hugh Dickins , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Song Liu , Rik van Riel , "Kirill A . Shutemov" , Johannes Weiner , Dave Chinner Subject: Re: [PATCH 2/2] fs: Do not update nr_thps for mappings which support THPs Message-ID: <20200916052126.GA12923@infradead.org> References: <20200916032717.22917-1-willy@infradead.org> <20200916032717.22917-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916032717.22917-2-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 16, 2020 at 04:27:17AM +0100, Matthew Wilcox (Oracle) wrote: > The nr_thps counter is to support THPs in the page cache when the > filesystem doesn't understand THPs. Eventually it will be removed, but > we should still support filesystems which do not understand THPs yet. > Move the nr_thp manipulation functions to filemap.h since they're > page-cache specific. Honestly I don't think we should support the read-only THP crap. We should in fact never have merged that bandaid to start with given that you did good progress on the real thing.