From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD0AC2D0E3 for ; Tue, 15 Sep 2020 23:04:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77E2D206DC for ; Tue, 15 Sep 2020 23:04:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fNkMvav0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77E2D206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB8516B0145; Tue, 15 Sep 2020 19:04:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A69EA6B0147; Tue, 15 Sep 2020 19:04:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 931946B0148; Tue, 15 Sep 2020 19:04:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 7B17F6B0145 for ; Tue, 15 Sep 2020 19:04:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3C8388249980 for ; Tue, 15 Sep 2020 23:04:43 +0000 (UTC) X-FDA: 77266827246.06.sofa37_610aa4e27115 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id E810A10062CB1 for ; Tue, 15 Sep 2020 23:04:42 +0000 (UTC) X-HE-Tag: sofa37_610aa4e27115 X-Filterd-Recvd-Size: 3757 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 23:04:42 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id m5so4880111lfp.7 for ; Tue, 15 Sep 2020 16:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vEeMulAJlc81CxL8jYeAKy63bDJ6gZhYcdxB7EqLKJE=; b=fNkMvav0lfQtCVj2Bt3dAtxGCGPFcMgoUEHIjTzrRzC+BNQMHiY/Zev6sKj0MUIbx2 9IvXtI3z06jmHRE+K/rUebptBUEzMek4Tx4PsrB32IKO5gL/Ji8HEgL0aRG9A7vkXV+1 22XamtQJlSEuGvaVNSR5KvT2Co0NTueHHbxZpwHEyvLakaqni/uRuooOD7sHv8b5Ny+u ZTtEDuUXSQxvvVMXY+wRXADnpzmvvYhbdV0T7LJGcXm753bPZRJkBBTD+qdVReqHMhWi HgMnC8zj56WNHdPQHw8sfu6/gK5pacdsoqwZyPQkN9LjBrccg4VA7AojniPyH3/nloGw siJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vEeMulAJlc81CxL8jYeAKy63bDJ6gZhYcdxB7EqLKJE=; b=WoqWhKskajJMX6BDvQfs2Rc8TVuHRA/0VYswgeLNsKCMqL2UyhC+tceeD3ZUPOgJM6 FKBoUSonj4CD04K0hnyvY5KCRvo8bYn07+rgwXcHzCKIXVe2+wilmAEWcgbU/Zpe63La 8faZiAz3hZUmiC5h6wx46l8runnujMqZFcXH+7PkCRMCPcOAa6/vTCMANyhOPb1qCxkL tSk8LPrWbtYtFWB49zgiYpuxavhe0Z/3+iP+3z7fNynVZXvTY9gwe1xwHfkbWYYr107q ve3bFvHvJRrWLXEifwd1sUcrZvnH/SIUtMAcXcaxSZPu/18iamReo3EU0UAkMr/T6Ds2 OrKw== X-Gm-Message-State: AOAM530hWBSuAvjwsRFM4w24UTEzzOAt9kHNMrFPN2rGFE0RUWTtkXjP PK/d2E1RMtKZIYILMKsFNudKtzV4kgDzGg== X-Google-Smtp-Source: ABdhPJyYjLqBWYc1CftrgwJvPN6OW5U8xYCyEGA9xFn2L+w1qPr9ICCcwW62XLCF8STOdiZhtRUa6Q== X-Received: by 2002:a19:ed17:: with SMTP id y23mr7436553lfy.595.1600211080755; Tue, 15 Sep 2020 16:04:40 -0700 (PDT) Received: from localhost.localdomain (188.147.112.12.nat.umts.dynamic.t-mobile.pl. [188.147.112.12]) by smtp.gmail.com with ESMTPSA id z6sm4258714lfq.297.2020.09.15.16.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 16:04:40 -0700 (PDT) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org Subject: [PATCH] mm/slab.c: clean code by removing redundant if condition Date: Wed, 16 Sep 2020 01:03:29 +0200 Message-Id: <20200915230329.13002-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: E810A10062CB1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.010682, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek The removed code was unnecessary and changed nothing in the flow, since in case of returning NULL by 'kmem_cache_alloc_node' returning 'freelist' from the function in question is the same as returning NULL. Signed-off-by: Mateusz Nosek --- mm/slab.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index 3160dff6fd76..8f2fd224c1f0 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -2301,8 +2301,6 @@ static void *alloc_slabmgmt(struct kmem_cache *cach= ep, /* Slab management obj is off-slab. */ freelist =3D kmem_cache_alloc_node(cachep->freelist_cache, local_flags, nodeid); - if (!freelist) - return NULL; } else { /* We will use last bytes at the slab for freelist */ freelist =3D addr + (PAGE_SIZE << cachep->gfporder) - --=20 2.20.1