From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 504FEC43461 for ; Wed, 16 Sep 2020 00:49:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B365420936 for ; Wed, 16 Sep 2020 00:48:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bVYT1hmr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B365420936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D53ED8E0005; Tue, 15 Sep 2020 20:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE4758E0001; Tue, 15 Sep 2020 20:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF2D48E0005; Tue, 15 Sep 2020 20:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id A523B8E0001 for ; Tue, 15 Sep 2020 20:48:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5DF138249980 for ; Wed, 16 Sep 2020 00:48:58 +0000 (UTC) X-FDA: 77267089956.06.worm78_6009a2d27115 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 2D4D31009C0D4 for ; Wed, 16 Sep 2020 00:48:58 +0000 (UTC) X-HE-Tag: worm78_6009a2d27115 X-Filterd-Recvd-Size: 1959 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 00:48:57 +0000 (UTC) Received: from X1 (unknown [67.22.170.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FC9420770; Wed, 16 Sep 2020 00:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600217336; bh=WyF3P7Aqu/5jOAe8bgWDIiaXqgmy/5Hi7Hqfi1YYGxM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bVYT1hmrZROX6bU3uwWE4x610xoug0ite08lGt2IcjKJ6EyBQJmob8oF/a7+334XQ 70TOEGz0Btq6bzmP3GD+86mAZXStilE+tuTXtJArwowTBMTdNdU0NWgFPUAFg3s93/ t07TYXV5YLomk2UW96M71H3gFsP6l2Ufvl5+iH6o= Date: Tue, 15 Sep 2020 17:48:55 -0700 From: Andrew Morton To: Cc: , Subject: Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be 'unsigned long' Message-Id: <20200915174855.822d866316948aadb8193e9b@linux-foundation.org> In-Reply-To: <20200915104620.20582-1-yanfei.xu@windriver.com> References: <20200915104620.20582-1-yanfei.xu@windriver.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2D4D31009C0D4 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 15 Sep 2020 18:46:20 +0800 wrote: > From: Yanfei Xu > > try_to_free_pages returns the number of pages reclaimed, and the type of > returns is 'unsigned long'. So we should use a matched type for storing > it. > __perform_reclaim() returns an int, so this change is fairly pointless. However __perform_reclaim()'s single caller expects it to return unsigned long, so including that change in this patch would make more sense.