From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924EEC43461 for ; Tue, 15 Sep 2020 17:25:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 24C7C21D1B for ; Tue, 15 Sep 2020 17:25:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Ok9Da4Vf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24C7C21D1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 83CF190006E; Tue, 15 Sep 2020 13:25:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C4FA900066; Tue, 15 Sep 2020 13:25:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68D4C90006E; Tue, 15 Sep 2020 13:25:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 4F35F900066 for ; Tue, 15 Sep 2020 13:25:23 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1026F8249980 for ; Tue, 15 Sep 2020 17:25:23 +0000 (UTC) X-FDA: 77265972126.18.milk53_00160d427113 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id BA2DF100ED3CB for ; Tue, 15 Sep 2020 17:25:22 +0000 (UTC) X-HE-Tag: milk53_00160d427113 X-Filterd-Recvd-Size: 4131 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 17:25:22 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id g128so4927448iof.11 for ; Tue, 15 Sep 2020 10:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+B6SfTmbRLE/LfIRwMpjpXfXUi1jL1qvGc+N8ykkERI=; b=Ok9Da4Vf/W1wPTsr/vAXSayisJPsO041Aeg3Igtr8glIIqRJt13m1NF6tPwRYNSyaZ iiTvf20x/9ZAQtB1M1kujLkF7tqDVbkoDwsZTekDgSXBaDzhW1p2eKHRqCoKdwL2d/7s XzWHl8zJsur5ohdCESQBYpqRdfc+2wwomEbfXvGyIszSa4B45soiTt9SFJgPRi0Q76ED qfAS2TSpEK2sGKvFtM4j6+i3SaAVyBEIN1hXmzFLRQj7Lv1LCcRtDjKnYd3fnDnIRMhS 2SZeVMIiISGpuIhWMk3kt/5kprWN4GOxoIy3KXmQ6jYumkll88xi/x6NYBVocXk+CfXN cEMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+B6SfTmbRLE/LfIRwMpjpXfXUi1jL1qvGc+N8ykkERI=; b=SpAgf1RTrTiTWHIwp8J4goQGrFh1IEP+UUU94h86VQCQ7WH80sWcctd9CsV5A0/Fk0 el+9Z3srzsrY32YCTV+x3BDFXEytrM8MAsPfuTaPaHeMhGnJnEcMdho2qveRuGIJcxIB HZss+NdqLxItKofS4tBrN0fEHvj/hZvid66anKgm/QznJTiltIbW5Ht2thHnfLZ0bkX2 xggmDq25+bhZbZZu7UcxeptTafiQTBZWkynqL+Y60Y/WAoXXLOcLYs1LfFnhpnJ3mfdS LhnkNO0yW7DiVbG0unN3yLdSIJw7h0F3qHTRlSwVT7O2eUdDmwhxCbQ7V9g6cpWoKsQE NVag== X-Gm-Message-State: AOAM531sOSs0cgY7vdvsxTCR6GxND78NuzMx7k8Zq580okC6ZoSEk07c soBCYOZYhnYmRp3tN62KWkEehQ== X-Google-Smtp-Source: ABdhPJymvc5riRPwnED++gXip8Ks7OVyQSEGj+RzOI/P4r0s4LZBjXreZCcZFsoRDRY5VijDMlIrMw== X-Received: by 2002:a6b:6d07:: with SMTP id a7mr15724555iod.82.1600190721636; Tue, 15 Sep 2020 10:25:21 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id t10sm8071240iog.49.2020.09.15.10.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 10:25:20 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kIEhj-006WFS-Fg; Tue, 15 Sep 2020 14:25:19 -0300 Date: Tue, 15 Sep 2020 14:25:19 -0300 From: Jason Gunthorpe To: John Hubbard Cc: Andrew Morton , Shuah Khan , LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/2] selftests/vm: fix incorrect gcc invocation in some cases Message-ID: <20200915172519.GL1221970@ziepe.ca> References: <20200915012901.1655280-1-jhubbard@nvidia.com> <20200915012901.1655280-3-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915012901.1655280-3-jhubbard@nvidia.com> X-Rspamd-Queue-Id: BA2DF100ED3CB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.009393, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 14, 2020 at 06:29:01PM -0700, John Hubbard wrote: > Avoid accidental wrong builds, due to built-in rules working just a > little bit too well--but not quite as well as required for our situation > here. > > In other words, "make userfaultfd" (for example) is supposed to fail to > build at all, because this Makefile only supports either "make" (all), > or "make /full/path". However, the built-in rules, if not suppressed, > will pick up CFLAGS and the initial LDLIBS (but not the target-specific > LDLIBS, because those are only set for the full path target!). This > causes it to get pretty far into building things despite using incorrect > values such as an *occasionally* incomplete LDLIBS value. > > Signed-off-by: John Hubbard > --- > tools/testing/selftests/vm/Makefile | 12 ++++++++++++ > 1 file changed, 12 insertions(+) I hit this too when fiddling with the hmm tests! Would be happy to see better errors Jason