From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB967C43461 for ; Tue, 15 Sep 2020 16:26:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5408820872 for ; Tue, 15 Sep 2020 16:26:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="R2LVUI6b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5408820872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD033900063; Tue, 15 Sep 2020 12:26:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7F7E90000E; Tue, 15 Sep 2020 12:26:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B965D900063; Tue, 15 Sep 2020 12:26:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id A308690000E for ; Tue, 15 Sep 2020 12:26:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 648D78249980 for ; Tue, 15 Sep 2020 16:26:07 +0000 (UTC) X-FDA: 77265822774.24.time26_200715127112 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 3E4801A4A5 for ; Tue, 15 Sep 2020 16:26:07 +0000 (UTC) X-HE-Tag: time26_200715127112 X-Filterd-Recvd-Size: 3513 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 16:26:06 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id x14so3958413wrl.12 for ; Tue, 15 Sep 2020 09:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dHrapBwpsWvrvFzuOTk0uSyWUcs2j2nE+q6aaks+S8Q=; b=R2LVUI6b3LVxmcrTw2T207w1f3CmBOTEi9U99KcQFNJPkUZB7c1kk0ZIGwsU/OCBLe /HEcFoxE65avOGVOhNe5ISlZ8qfobmAoFadWBJ+ndYPWqhHZ6joZqsANBSU8I0IZQJEA BpabIz5FjIi843oMPOrEpHjSITrza8CPGZVaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dHrapBwpsWvrvFzuOTk0uSyWUcs2j2nE+q6aaks+S8Q=; b=tNmEqwfdF9RLxfqQabcoBR0YUDtQ2iO+63RRKLlZ6/nV6aUI7wMqkvJmcZ1lYK7BO0 Ibxt0TG55/gQei/ICLO1//xBzpkkHUzaBvmEv0cYdJ/oX7TOB6IFxKjjKtEZ7+ncfc6u bw6QgpMGu/CnfnrQ94uYgUNRi8d+V/jtSRv2HSVbTbwKFy3ifs7znEjHwQlzDrHhnc4Q b2DPz6fpkSDgA1OwTq3C1jWJ8exQj22JEEnoRR2U3TKV0AzK6WAEgpXED19ila4d+X6f 2yV5m2LZMuMUKhxxhVvcy3gHckX4W+P+HRcQ0rVQ+mMbiPA/Hm5XiiozXJHU6TcwbEbe Zzew== X-Gm-Message-State: AOAM531XJ/gqWnSJm9m/4UzIyeoqzr4iRNpMSveCG2I2yg4vLA7dT6oB hDiQx5aKSKKyzD9FAky2VLb6pg== X-Google-Smtp-Source: ABdhPJxFWQTqFtIMY9NdvgB0CMac9uqPY+ZYKj6rRgzYfi5dn22n5jRh3rLISvWGGwuJeZam3KVBxQ== X-Received: by 2002:a5d:6301:: with SMTP id i1mr21382993wru.323.1600187165281; Tue, 15 Sep 2020 09:26:05 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id 92sm29778577wra.19.2020.09.15.09.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 09:26:04 -0700 (PDT) Date: Tue, 15 Sep 2020 17:26:04 +0100 From: Chris Down To: Michal Hocko Cc: zangchunxin@bytedance.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node Message-ID: <20200915162604.GB2581123@chrisdown.name> References: <20200915132741.84869-1-zangchunxin@bytedance.com> <20200915144737.GA2581123@chrisdown.name> <20200915145533.GG3736@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200915145533.GG3736@dhcp22.suse.cz> User-Agent: Mutt/1.14.6 (2020-07-11) X-Rspamd-Queue-Id: 3E4801A4A5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000744, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Michal Hocko writes: >On Tue 15-09-20 15:47:37, Chris Down wrote: >> zangchunxin@bytedance.com writes: >> > + if (signal_pending(current)) >> > + return; >> >> This doesn't match your patch title, please update it. :-) > >I have to admit I have completely missed this and I think that this >should better be fatal_signal_pending because that would make sure that >the userspace will not see an incomplete operation. This is a general >practice for other bail outs as well. Oh sorry, to be clear, I meant the patch should match the title, not the other way around.