From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA62C43461 for ; Tue, 15 Sep 2020 16:18:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75E68206DC for ; Tue, 15 Sep 2020 16:18:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZFWtCczm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75E68206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B00A90005B; Tue, 15 Sep 2020 12:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05F9090000E; Tue, 15 Sep 2020 12:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E42AA90005B; Tue, 15 Sep 2020 12:18:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id CB9F490000E for ; Tue, 15 Sep 2020 12:18:20 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8F5131DE1 for ; Tue, 15 Sep 2020 16:18:20 +0000 (UTC) X-FDA: 77265803160.11.bear00_33138ec27112 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 5477A180F8B82 for ; Tue, 15 Sep 2020 16:18:20 +0000 (UTC) X-HE-Tag: bear00_33138ec27112 X-Filterd-Recvd-Size: 4271 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 16:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600186699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GfwuuWWzGYHhzmOr9zWk/h6mAKg0sY0tXHg31ZT1k8E=; b=ZFWtCczmGJtrqy6FsCmOg+K5KYo84lH6p2vGR3M2z5d65xB+AhBYK0WbMMAGct4oBkYOI+ p00Uf1casl1u3sAWxpOoXxXwmduAzY6IJxyXKI+OEAg7yfdSd3ES2qP+ZquC9ZDB/MbfGN 3pkooDCAX4hcknz7tEmP9P5PXfFRyUg= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-W1dtVWnIPk-Q7X_LA5Ialg-1; Tue, 15 Sep 2020 12:18:17 -0400 X-MC-Unique: W1dtVWnIPk-Q7X_LA5Ialg-1 Received: by mail-qk1-f197.google.com with SMTP id j5so3257016qka.7 for ; Tue, 15 Sep 2020 09:18:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GfwuuWWzGYHhzmOr9zWk/h6mAKg0sY0tXHg31ZT1k8E=; b=CyMd6qeTyrJHECaSvXAVdOFvCmPf6kdgOryWWyMpcbL0I5z0yL/OM7Lut//yt8a9Uz byTQ/SQwsTgHe1fkKJGcSoVk+hM7TkYbmRINhd5pivuwHPY3KyzlOjlEqFJk0qQY0ARm x0b8xTpukVCnhd1zQm26d4qaBkxosug8s24mHzPQhOf7oY90JCyQWb2LQPeQuDbkgSxc 7bx2oSHBiVGellhZJxQMnmLRwHuDFajkda+LH7tcxku7HtPh5I9wSqSRi8JnDTMU83eh 1X/MqQUTNWXU6rfVJlpsQ1lCUdEZohMNw4jo3lG93QuBmmoj9xryZU+7xM6CO8WEoMJo YA2A== X-Gm-Message-State: AOAM533V1WuCk0o85SxFpD6mfQgqeKHSP98WCEiScShAwrkeK5Krie7Y u8dCYiTgrw1X3vJzNlOlfX7ZPGrs0xVOpLmNUBhKHQD1u1pvT7PXI0LW/60yNqSaTdTtcfKn3ly 8/AisE3AooqM= X-Received: by 2002:a37:64d4:: with SMTP id y203mr18363465qkb.359.1600186697196; Tue, 15 Sep 2020 09:18:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLVW8kuvMeh2di7XK6DC3uhyQVMeMlC0qltufBS9xG4VLH4xrOs73HZvyOAteqZrQAnOU8WA== X-Received: by 2002:a37:64d4:: with SMTP id y203mr18363431qkb.359.1600186696948; Tue, 15 Sep 2020 09:18:16 -0700 (PDT) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-11-70-53-122-15.dsl.bell.ca. [70.53.122.15]) by smtp.gmail.com with ESMTPSA id u46sm16483548qth.31.2020.09.15.09.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 09:18:15 -0700 (PDT) Date: Tue, 15 Sep 2020 12:18:14 -0400 From: Peter Xu To: Oleg Nesterov Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Maya B . Gokhale" , Linus Torvalds , Yang Shi , Marty Mcfadden , Kirill Shutemov , Jann Horn , Jan Kara , Kirill Tkhai , Andrea Arcangeli , Christoph Hellwig , Andrew Morton Subject: Re: [PATCH 1/4] mm: Trial do_wp_page() simplification Message-ID: <20200915161814.GC2949@xz-x1> References: <20200821234958.7896-1-peterx@redhat.com> <20200821234958.7896-2-peterx@redhat.com> <20200915150349.GA22415@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200915150349.GA22415@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 5477A180F8B82 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 15, 2020 at 05:03:49PM +0200, Oleg Nesterov wrote: > > - if (reuse_swap_page(vmf->page, &total_map_swapcount)) { > > It seems that nobody else calls reuse_swap_page() with total_map_swapcount != NULL. Seems correct. Though maybe we could postpone the cleanup later, until the fallouts of the cow rework settle (just in case we'd like to bring some mapcount logic back). Thanks, -- Peter Xu