From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66171C43461 for ; Tue, 15 Sep 2020 14:55:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDB8F206DC for ; Tue, 15 Sep 2020 14:55:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDB8F206DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 559336B00FB; Tue, 15 Sep 2020 10:55:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 509656B00FC; Tue, 15 Sep 2020 10:55:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4217D6B00FD; Tue, 15 Sep 2020 10:55:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id 2D7D86B00FB for ; Tue, 15 Sep 2020 10:55:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D4B05180AD80F for ; Tue, 15 Sep 2020 14:55:38 +0000 (UTC) X-FDA: 77265594756.11.joke72_2c02fb727112 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 9315A180F8B82 for ; Tue, 15 Sep 2020 14:55:37 +0000 (UTC) X-HE-Tag: joke72_2c02fb727112 X-Filterd-Recvd-Size: 1602 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 14:55:36 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 44D92AC7D; Tue, 15 Sep 2020 14:55:50 +0000 (UTC) Date: Tue, 15 Sep 2020 16:55:33 +0200 From: Michal Hocko To: Chris Down Cc: zangchunxin@bytedance.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node Message-ID: <20200915145533.GG3736@dhcp22.suse.cz> References: <20200915132741.84869-1-zangchunxin@bytedance.com> <20200915144737.GA2581123@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915144737.GA2581123@chrisdown.name> X-Rspamd-Queue-Id: 9315A180F8B82 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 15-09-20 15:47:37, Chris Down wrote: > zangchunxin@bytedance.com writes: > > + if (signal_pending(current)) > > + return; > > This doesn't match your patch title, please update it. :-) I have to admit I have completely missed this and I think that this should better be fatal_signal_pending because that would make sure that the userspace will not see an incomplete operation. This is a general practice for other bail outs as well. > After that, you can add: > > Acked-by: Chris Down -- Michal Hocko SUSE Labs