From: Michal Hocko <mhocko@suse.com>
To: Chris Down <chris@chrisdown.name>
Cc: zangchunxin@bytedance.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node
Date: Tue, 15 Sep 2020 16:55:33 +0200 [thread overview]
Message-ID: <20200915145533.GG3736@dhcp22.suse.cz> (raw)
In-Reply-To: <20200915144737.GA2581123@chrisdown.name>
On Tue 15-09-20 15:47:37, Chris Down wrote:
> zangchunxin@bytedance.com writes:
> > + if (signal_pending(current))
> > + return;
>
> This doesn't match your patch title, please update it. :-)
I have to admit I have completely missed this and I think that this
should better be fatal_signal_pending because that would make sure that
the userspace will not see an incomplete operation. This is a general
practice for other bail outs as well.
> After that, you can add:
>
> Acked-by: Chris Down <chris@chrisdown.name>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-09-15 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 13:27 zangchunxin
2020-09-15 13:37 ` Michal Hocko
2020-09-15 14:47 ` Chris Down
2020-09-15 14:55 ` Michal Hocko [this message]
2020-09-15 16:26 ` Chris Down
2020-09-16 2:36 ` [External] " Chunxin Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915145533.GG3736@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
--cc=zangchunxin@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox