From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A69C43461 for ; Tue, 15 Sep 2020 10:31:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5A5D52076C for ; Tue, 15 Sep 2020 10:31:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A5D52076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B8F6C90002F; Tue, 15 Sep 2020 06:31:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3F53900017; Tue, 15 Sep 2020 06:31:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A548790002F; Tue, 15 Sep 2020 06:31:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 8DF27900017 for ; Tue, 15 Sep 2020 06:31:50 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 54B403623 for ; Tue, 15 Sep 2020 10:31:50 +0000 (UTC) X-FDA: 77264929980.11.dust59_2500add27110 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 289E4180F8B81 for ; Tue, 15 Sep 2020 10:31:50 +0000 (UTC) X-HE-Tag: dust59_2500add27110 X-Filterd-Recvd-Size: 2400 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 10:31:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 02318B0F2; Tue, 15 Sep 2020 10:32:04 +0000 (UTC) Date: Tue, 15 Sep 2020 12:31:45 +0200 From: Oscar Salvador To: Laurent Dufour Cc: akpm@linux-foundation.org, David Hildenbrand , mhocko@suse.com, Greg Kroah-Hartman , linux-mm@kvack.org, "Rafael J . Wysocki" , nathanl@linux.ibm.com, cheloha@linux.ibm.com, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 2/3] mm: don't rely on system state to detect hot-plug operations Message-ID: <20200915103145.GB30015@linux> References: <20200915094143.79181-1-ldufour@linux.ibm.com> <20200915094143.79181-3-ldufour@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915094143.79181-3-ldufour@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 289E4180F8B81 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 15, 2020 at 11:41:42AM +0200, Laurent Dufour wrote: > [1] According to Oscar Salvador, using this qemu command line, ACPI memory > hotplug operations are raised at SYSTEM_SCHEDULING state: I would like to stress that this is not the only way we can end up hotplugging memor while state = SYSTEM_SCHEDULING. According to David, we can end up doing this if we reboot a VM with hotplugged memory. (And I have seen other virtualization technologies do the same) > Fixes: 4fbce633910e ("mm/memory_hotplug.c: make register_mem_sect_under_node() a callback of walk_memory_range()") > Signed-off-by: Laurent Dufour > Reviewed-by: David Hildenbrand > Cc: stable@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Oscar Salvador Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3