From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8304DC433E2 for ; Mon, 14 Sep 2020 11:37:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D6D921741 for ; Mon, 14 Sep 2020 11:37:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D6D921741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 645DE6B0055; Mon, 14 Sep 2020 07:37:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F86A6B005A; Mon, 14 Sep 2020 07:37:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50C056B005C; Mon, 14 Sep 2020 07:37:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id 3B0FD6B0055 for ; Mon, 14 Sep 2020 07:37:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EBF8618043DC6 for ; Mon, 14 Sep 2020 11:37:24 +0000 (UTC) X-FDA: 77261466408.15.store49_4e0cf0a27108 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id B918418144D21 for ; Mon, 14 Sep 2020 11:37:24 +0000 (UTC) X-HE-Tag: store49_4e0cf0a27108 X-Filterd-Recvd-Size: 2586 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 11:37:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A9154AD0F; Mon, 14 Sep 2020 11:37:38 +0000 (UTC) Date: Mon, 14 Sep 2020 13:37:22 +0200 From: Michal Hocko To: Waiman Long Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , Tejun Heo , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Chris Down , Roman Gushchin , Yafang Shao Subject: Re: [PATCH v2 1/3] mm/memcg: Clean up obsolete enum charge_type Message-ID: <20200914113722.GL16999@dhcp22.suse.cz> References: <20200914024452.19167-1-longman@redhat.com> <20200914024452.19167-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200914024452.19167-2-longman@redhat.com> X-Rspamd-Queue-Id: B918418144D21 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 13-09-20 22:44:50, Waiman Long wrote: > Since commit 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API") and > commit 00501b531c47 ("mm: memcontrol: rewrite charge API") in v3.17, the > enum charge_type was no longer used anywhere. However, the enum itself > was not removed at that time. Remove the obsolete enum charge_type now. > > Signed-off-by: Waiman Long > Acked-by: Johannes Weiner > Reviewed-by: Shakeel Butt Acked-by: Michal Hocko > --- > mm/memcontrol.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index cfa6cbad21d5..8c74f1200261 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -197,14 +197,6 @@ static struct move_charge_struct { > #define MEM_CGROUP_MAX_RECLAIM_LOOPS 100 > #define MEM_CGROUP_MAX_SOFT_LIMIT_RECLAIM_LOOPS 2 > > -enum charge_type { > - MEM_CGROUP_CHARGE_TYPE_CACHE = 0, > - MEM_CGROUP_CHARGE_TYPE_ANON, > - MEM_CGROUP_CHARGE_TYPE_SWAPOUT, /* for accounting swapcache */ > - MEM_CGROUP_CHARGE_TYPE_DROP, /* a page was unused swap cache */ > - NR_CHARGE_TYPE, > -}; > - > /* for encoding cft->private value on file */ > enum res_type { > _MEM, > -- > 2.18.1 > -- Michal Hocko SUSE Labs