From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52069C43461 for ; Mon, 14 Sep 2020 10:46:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6E88207BB for ; Mon, 14 Sep 2020 10:46:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E88207BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0FB9B8E0001; Mon, 14 Sep 2020 06:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 085326B005A; Mon, 14 Sep 2020 06:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB68D8E0001; Mon, 14 Sep 2020 06:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id D31536B0003 for ; Mon, 14 Sep 2020 06:46:44 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9027739BA9 for ; Mon, 14 Sep 2020 10:46:44 +0000 (UTC) X-FDA: 77261338728.13.cent80_020a05827108 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 58CEB1811CE46 for ; Mon, 14 Sep 2020 10:46:44 +0000 (UTC) X-HE-Tag: cent80_020a05827108 X-Filterd-Recvd-Size: 2398 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 10:46:43 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 492D7AC23; Mon, 14 Sep 2020 10:46:58 +0000 (UTC) Date: Mon, 14 Sep 2020 12:46:42 +0200 From: Michal Hocko To: Miaohe Lin Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter() Message-ID: <20200914104642.GJ16999@dhcp22.suse.cz> References: <20200913094129.44558-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200913094129.44558-1-linmiaohe@huawei.com> X-Rspamd-Queue-Id: 58CEB1811CE46 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 13-09-20 05:41:29, Miaohe Lin wrote: > Since commit bbec2e15170a ("mm: rename page_counter's count/limit into > usage/max"), the arg @reclaim has no priority field anymore. The priority field has been removed by 9da83f3fc74b ("mm, memcg: clean up reclaim iter array") > > Signed-off-by: Miaohe Lin Other than that Acked-by: Michal Hocko > --- > mm/memcontrol.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 75cd1a1e66c8..a57aa0f42d40 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1138,9 +1138,9 @@ static __always_inline struct mem_cgroup *get_mem_cgroup_from_current(void) > * invocations for reference counting, or use mem_cgroup_iter_break() > * to cancel a hierarchy walk before the round-trip is complete. > * > - * Reclaimers can specify a node and a priority level in @reclaim to > - * divide up the memcgs in the hierarchy among all concurrent > - * reclaimers operating on the same node and priority. > + * Reclaimers can specify a node in @reclaim to divide up the memcgs > + * in the hierarchy among all concurrent reclaimers operating on the > + * same node. > */ > struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root, > struct mem_cgroup *prev, > -- > 2.19.1 -- Michal Hocko SUSE Labs