From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2059C433E2 for ; Mon, 14 Sep 2020 08:59:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 95255221EF for ; Mon, 14 Sep 2020 08:59:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95255221EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E728E6B0037; Mon, 14 Sep 2020 04:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E22056B0055; Mon, 14 Sep 2020 04:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5F736B005A; Mon, 14 Sep 2020 04:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id BEEB66B0037 for ; Mon, 14 Sep 2020 04:59:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 88ABB83D94D2 for ; Mon, 14 Sep 2020 08:59:55 +0000 (UTC) X-FDA: 77261069550.30.match62_5e108e127107 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 48B731815AA32 for ; Mon, 14 Sep 2020 08:59:55 +0000 (UTC) X-HE-Tag: match62_5e108e127107 X-Filterd-Recvd-Size: 1958 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 08:59:54 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3C5D9AC46; Mon, 14 Sep 2020 09:00:09 +0000 (UTC) Date: Mon, 14 Sep 2020 10:59:53 +0200 From: Michal Hocko To: Laurent Dufour Cc: akpm@linux-foundation.org, David Hildenbrand , Oscar Salvador , Greg Kroah-Hartman , linux-mm@kvack.org, "Rafael J . Wysocki" , nathanl@linux.ibm.com, cheloha@linux.ibm.com, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: replace memmap_context by memplug_context Message-ID: <20200914085953.GD16999@dhcp22.suse.cz> References: <20200911134831.53258-1-ldufour@linux.ibm.com> <20200911134831.53258-2-ldufour@linux.ibm.com> <20200914084904.GA16999@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 48B731815AA32 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 14-09-20 10:51:06, Laurent Dufour wrote: > Le 14/09/2020 =E0 10:49, Michal Hocko a =E9crit=A0: [...] > > /* > > * Memory initialization context, use to differentiate memory added = by > > * the platform statically or via memory hotplug interface. > > */ > > enum meminit_context { > > MEMINIT_EARLY, > > MEMINIT_HOTPLUG > > } > >=20 >=20 > Sounds good too. > What about its definition's place, in include/mm/zone.h as David sugges= ted ? Yes. This shouldn't be in the hotplug proper. --=20 Michal Hocko SUSE Labs