From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F3E9C433E2 for ; Sun, 13 Sep 2020 19:05:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 746C722206 for ; Sun, 13 Sep 2020 19:05:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CAV3/VeH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 746C722206 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 488416B0002; Sun, 13 Sep 2020 15:05:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4396C6B0037; Sun, 13 Sep 2020 15:05:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 301366B0055; Sun, 13 Sep 2020 15:05:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 1B2E56B0002 for ; Sun, 13 Sep 2020 15:05:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D1F9A181AEF09 for ; Sun, 13 Sep 2020 19:05:55 +0000 (UTC) X-FDA: 77258967870.23.art53_390feeb27102 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 9F8008CF9C for ; Sun, 13 Sep 2020 19:05:55 +0000 (UTC) X-HE-Tag: art53_390feeb27102 X-Filterd-Recvd-Size: 3752 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Sun, 13 Sep 2020 19:05:55 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id x23so8690240wmi.3 for ; Sun, 13 Sep 2020 12:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+MxfKNTuc5VaN6NhuE64EHSS6797wnf2U/mP1kKdFwc=; b=CAV3/VeHI9C7tBfKwJF+Xb1SxPkVApKxSnGc/3niqF3X3bY1MWyHsvU0kNq/2QSBgp t+327+GaFZYInKdrgbiHXyfMOsEbE7wUArcxKlmjR/j6RxTXwO+yHRYmlrUNxMSVTwBq jqqWIgecIWiGoUZUgh+IwFd7rOKc8rzmZT8fUglNTadL9dTkoqDeRVO6oQ+o+1bgi8n8 4ASsTBMh0cD3o94wikrmGlJQZ8WNq0nfXsD9K2vjZLsSEE4MVwF/7dn5AiUmJ5XeDwm7 tq1QkZU1vlxoRJzFntBehUNxK2kakEKBKpLyMkGZMY/0VtS4qtN8L6TlQCsnMErGfzps E4xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+MxfKNTuc5VaN6NhuE64EHSS6797wnf2U/mP1kKdFwc=; b=URuXxvGrRPDh2qSDnydLv79u7Z7eyv/baT00HD4pz//YeAWqO+aKiqn1DjSL2zzEqN Xu5EXhwTnEyCJhaZnCv+l5/mbeWM5o3EDeEqdfG0R6c/2xewQrKqA1DoEwd4xQBrZCV7 wFPovpUcVyx4xFEHeJW+MEguS+g9wky5vtsuLIqHv1jKAjkY5UzcvsxueggpqfFz4GFh fLEtympYV10tJHoOuKfd8Rg6r+0+PehOm/m8MdCfXajFP9SRdBxclOLSnRwuC80iauNy TEpldsxWnoiCXOi4o/lPt5Db1CPNVINbbfWOqwp+IXRA+vlnMlWLh+FHF0Q5fV26SRS8 Y8Kw== X-Gm-Message-State: AOAM533ZP4618lKYpRMbyLIs0xE+tfkMQWXOGrzsWRXgN2BCx7NyXrGj sNt8OsTtbVoligSn4j7MkguGRUkIu8LyTQ== X-Google-Smtp-Source: ABdhPJw1qSOkBvhUTpOm91xMXLIJT5GYg4KVIOwW74nnima+ZYwdCFfu7zwykBnPI6ITyj4C1uWi5g== X-Received: by 2002:a1c:e904:: with SMTP id q4mr9287528wmc.151.1600023953846; Sun, 13 Sep 2020 12:05:53 -0700 (PDT) Received: from localhost.localdomain (188.147.111.252.nat.umts.dynamic.t-mobile.pl. [188.147.111.252]) by smtp.gmail.com with ESMTPSA id j14sm17326955wrr.66.2020.09.13.12.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 12:05:53 -0700 (PDT) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , akpm@linux-foundation.org Subject: [PATCH] mm/compaction.c: micro-optimization remove unnecessary branch Date: Sun, 13 Sep 2020 21:04:48 +0200 Message-Id: <20200913190448.28649-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 9F8008CF9C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek The same code can work both for 'zone->compact_considered > defer_limit' and 'zone->compact_considered >=3D defer_limit'. In the latter there is o= ne branch less which is more effective considering performance. Signed-off-by: Mateusz Nosek --- mm/compaction.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 176dcded298e..6c63844fc061 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -180,11 +180,10 @@ bool compaction_deferred(struct zone *zone, int ord= er) return false; =20 /* Avoid possible overflow */ - if (++zone->compact_considered > defer_limit) + if (++zone->compact_considered >=3D defer_limit) { zone->compact_considered =3D defer_limit; - - if (zone->compact_considered >=3D defer_limit) return false; + } =20 trace_mm_compaction_deferred(zone, order); =20 --=20 2.20.1