From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B58F4C433E2 for ; Sun, 13 Sep 2020 00:42:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 19F2D2087C for ; Sun, 13 Sep 2020 00:42:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="G6daZwQC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19F2D2087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C74D6B0002; Sat, 12 Sep 2020 20:42:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5780A6B0037; Sat, 12 Sep 2020 20:42:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48D056B0055; Sat, 12 Sep 2020 20:42:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 345FB6B0002 for ; Sat, 12 Sep 2020 20:42:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EF0F820302 for ; Sun, 13 Sep 2020 00:42:43 +0000 (UTC) X-FDA: 77256187806.12.hand64_6214818270fb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id C61C5180FCFA1 for ; Sun, 13 Sep 2020 00:42:43 +0000 (UTC) X-HE-Tag: hand64_6214818270fb X-Filterd-Recvd-Size: 1860 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Sun, 13 Sep 2020 00:42:43 +0000 (UTC) Received: from X1 (unknown [209.33.215.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F20972087C; Sun, 13 Sep 2020 00:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599957762; bh=zWEjpsPiw3tRbjW3SotHs8K4FaJz/c98OlcLD4VZ/Dw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G6daZwQC9E45NL2heKtVG8/msTxuibvIJ6YUkqfpGHxV6KdQKOjvb2WwlBnCDDbnP paIS6oXa7OSwrOL1GK4t3UQ7V+V4W5dKteT3iN0kfMOuVP2j2uwpHNfeZwJQFBAdyT aNQC2h1TvgEYoKNi72Q0OOd/q9XzznkmSAKQVRk4= Date: Sat, 12 Sep 2020 17:42:41 -0700 From: Andrew Morton To: Muchun Song Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: Fix out-of-bounds on the buf returned by memory_stat_format Message-Id: <20200912174241.eeaa771755915f27babf9322@linux-foundation.org> In-Reply-To: <20200912155100.25578-1-songmuchun@bytedance.com> References: <20200912155100.25578-1-songmuchun@bytedance.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C61C5180FCFA1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 12 Sep 2020 23:51:00 +0800 Muchun Song wrote: > The memory_stat_format() returns a format string, but the return buf > may not including the trailing '\0'. So the users may read the buf > out of bounds. That sounds serious. Is a cc:stable appropriate?