From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1FA6C43461 for ; Thu, 10 Sep 2020 11:30:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 029222145D for ; Thu, 10 Sep 2020 11:30:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 029222145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 175966B0072; Thu, 10 Sep 2020 07:30:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1250B6B0073; Thu, 10 Sep 2020 07:30:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03B356B0078; Thu, 10 Sep 2020 07:30:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id E4DDA6B0072 for ; Thu, 10 Sep 2020 07:30:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A18D7362A for ; Thu, 10 Sep 2020 11:30:57 +0000 (UTC) X-FDA: 77246934954.21.glass02_220e731270e5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 78D03180442C3 for ; Thu, 10 Sep 2020 11:30:57 +0000 (UTC) X-HE-Tag: glass02_220e731270e5 X-Filterd-Recvd-Size: 2242 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Sep 2020 11:30:57 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6A19AAD52; Thu, 10 Sep 2020 11:31:11 +0000 (UTC) Date: Thu, 10 Sep 2020 13:30:50 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [RFC 4/5] mm, page_alloc: cache pageset high and batch in struct zone Message-ID: <20200910113046.GA5848@linux> References: <20200907163628.26495-1-vbabka@suse.cz> <20200907163628.26495-5-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907163628.26495-5-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 78D03180442C3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 07, 2020 at 06:36:27PM +0200, Vlastimil Babka wrote: */ > -static void setup_pageset(struct per_cpu_pageset *p); > +static void pageset_init(struct per_cpu_pageset *p); this belongs to the respective patches > -static void zone_set_pageset_high_and_batch(struct zone *zone) > +static void zone_set_pageset_high_and_batch(struct zone *zone, bool force_update) > { > unsigned long new_high; > unsigned long new_batch; > @@ -6256,6 +6256,14 @@ static void zone_set_pageset_high_and_batch(struct zone *zone) > new_batch = max(1UL, 1 * new_batch); > } > > + if (zone->pageset_high != new_high || > + zone->pageset_batch != new_batch) { > + zone->pageset_high = new_high; > + zone->pageset_batch = new_batch; > + } else if (!force_update) { > + return; > + } I am probably missimg something obvious, so sorry, but why do we need force_update here? AFAICS, we only want to call pageset_update() in case zone->pageset_high/batch and the new computed high/batch differs, so if everything is equal, why do we want to call it anyways? -- Oscar Salvador SUSE L3