From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9423BC43461 for ; Thu, 10 Sep 2020 08:35:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 282B32076C for ; Thu, 10 Sep 2020 08:35:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 282B32076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B2AB6B005A; Thu, 10 Sep 2020 04:35:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53BE56B005C; Thu, 10 Sep 2020 04:35:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 403466B005D; Thu, 10 Sep 2020 04:35:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 27A566B005A for ; Thu, 10 Sep 2020 04:35:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DCC9B181AEF1D for ; Thu, 10 Sep 2020 08:35:03 +0000 (UTC) X-FDA: 77246491686.18.feet69_1f0a7e7270e4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id AF9D8100EC664 for ; Thu, 10 Sep 2020 08:35:03 +0000 (UTC) X-HE-Tag: feet69_1f0a7e7270e4 X-Filterd-Recvd-Size: 2034 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Sep 2020 08:35:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D18B8B20B; Thu, 10 Sep 2020 08:35:17 +0000 (UTC) Date: Thu, 10 Sep 2020 10:34:59 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [RFC 1/5] mm, page_alloc: clean up pageset high and batch update Message-ID: <20200910083459.GB2285@linux> References: <20200907163628.26495-1-vbabka@suse.cz> <20200907163628.26495-2-vbabka@suse.cz> <20200910083116.GA2285@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910083116.GA2285@linux> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: AF9D8100EC664 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 10, 2020 at 10:31:20AM +0200, Oscar Salvador wrote: > On Mon, Sep 07, 2020 at 06:36:24PM +0200, Vlastimil Babka wrote: > > Signed-off-by: Vlastimil Babka > > > for_each_possible_cpu(cpu) > > - setup_pageset(&per_cpu(boot_pageset, cpu), 0); > > + setup_pageset(&per_cpu(boot_pageset, cpu)); > > This is not really anything important but I realized we have like 7 functions > messing with pcp lists, and everytime I try to follow them my head spins. > > Since setup_pageset is only being called here, could we replace it by the > pageset_init and pageset_update? > > (As I said, not important and probably a matter of taste. I just think that > having so many mini functions around is not always cool, > e.g: setup_zone_pageset->zone_pageset_init) Sorry, I did not see that you just did that in Patch#3, bleh. -- Oscar Salvador SUSE L3