From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0751CC43461 for ; Wed, 9 Sep 2020 21:47:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 949E0205CB for ; Wed, 9 Sep 2020 21:47:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="VdNLtAuk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 949E0205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C84018E0001; Wed, 9 Sep 2020 17:47:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C339C6B0055; Wed, 9 Sep 2020 17:47:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B71958E0001; Wed, 9 Sep 2020 17:47:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id A1D106B0037 for ; Wed, 9 Sep 2020 17:47:28 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 68DCC8248047 for ; Wed, 9 Sep 2020 21:47:28 +0000 (UTC) X-FDA: 77244859776.19.salt60_3f12048270e0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 3AEC31AD1B9 for ; Wed, 9 Sep 2020 21:47:28 +0000 (UTC) X-HE-Tag: salt60_3f12048270e0 X-Filterd-Recvd-Size: 3483 Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Sep 2020 21:47:27 +0000 (UTC) Received: by mail-qv1-f66.google.com with SMTP id z18so2371972qvp.6 for ; Wed, 09 Sep 2020 14:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xtYCmEQsba5nU7Adim+7cup2FZgfTbjzNecUaihW994=; b=VdNLtAuk7HKQaA7HqX+LUbtgZnSfFuvpQaCBggc+pT4+BxuJlTRwuqxoMZzquD8MVy HB71euqA+l8n4Lx83SIe9PIEDFBXbJGXaIOeuuLOK03olUSLOHq9L1U77qwTFu0QQL91 zGlWwjfLThu0RMYywzur71reHHWY0v7N/vG+k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xtYCmEQsba5nU7Adim+7cup2FZgfTbjzNecUaihW994=; b=oEZpev6OeL4a2MdflJryICDM2OdhXYDx1HTZswti8NVD5ceCdQQhTploiNxcmeNH1W iuQR0f5Ba9yeGWvmjQuP7WhhUjZYRpk1jZ08IUbsNddjp7vmaeQtnFGjVgjQ5K6diE9U iptkSgvRbKpq/qxPOohHsjPVh1GJkFL9aXfiK872Vtj6LZF26MqCP1sO3xavSIvl4BqD nwMoycHXZxDAq3ALOjc8AfR/Gr5Tbk0n6Z71gS+slNA2owpvtdFxoWmx3/NpXtfpQQAk /0nr1yaf40VNo2NxoGB+RP++gBTdfF+R2Fw2ABk8dpx+ncwVmwmBhzIgNHWXN+C2ThsV 1CrQ== X-Gm-Message-State: AOAM531lIbku5k7RFofl58/t+vsa9OxSgZg+8Y5qoFFO/OPyTuxVeRru iKZohtSxR4vmBDyXRaPH1SumTw== X-Google-Smtp-Source: ABdhPJwqCV2yXcXhKFR1TB9YyHsR+Lsm8QbQvzSAdlll2vj33PUfAr9wPVAOCsB1mMqleS0agNrCtA== X-Received: by 2002:ad4:5745:: with SMTP id q5mr6043849qvx.29.1599688046933; Wed, 09 Sep 2020 14:47:26 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:16fd]) by smtp.gmail.com with ESMTPSA id 7sm4059450qkh.60.2020.09.09.14.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 14:47:26 -0700 (PDT) Date: Wed, 9 Sep 2020 22:47:24 +0100 From: Chris Down To: Vlastimil Babka Cc: zangchunxin@bytedance.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH v2] mm/vmscan: fix infinite loop in drop_slab_node Message-ID: <20200909214724.GA1577471@chrisdown.name> References: <20200909152047.27905-1-zangchunxin@bytedance.com> <16906d44-9e3c-76a1-f1a9-ced61e865467@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <16906d44-9e3c-76a1-f1a9-ced61e865467@suse.cz> User-Agent: Mutt/1.14.6 (2020-07-11) X-Rspamd-Queue-Id: 3AEC31AD1B9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Vlastimil Babka writes: >- Exit also on other signals such as SIGABRT, SIGTERM? If I write to drop_caches >and think it's too long, I would prefer to kill it by ctrl-c and not just kill Oh dear, fatal_signal_pending() doesn't consider cases with no more userspace instructions due to SIG_DFL on TERM/INT etc, that seems misleading :-( I had (naively) believed it internally checks the same set as TASK_KILLABLE. Chuxin, Muchun, can you please make it work using TASK_KILLABLE in a similar way to how schedule_timeout_killable and friends do it instead, so that other signals will be caught?