From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE38C433E2 for ; Wed, 9 Sep 2020 16:09:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4B43720758 for ; Wed, 9 Sep 2020 16:09:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="LoZsiyRN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B43720758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 681836B0073; Wed, 9 Sep 2020 12:09:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 631C16B0074; Wed, 9 Sep 2020 12:09:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5477F900003; Wed, 9 Sep 2020 12:09:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 431DC6B0073 for ; Wed, 9 Sep 2020 12:09:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E9259824934B for ; Wed, 9 Sep 2020 16:09:20 +0000 (UTC) X-FDA: 77244007680.18.men86_390c5d3270de Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 7CA8D100ED585 for ; Wed, 9 Sep 2020 16:09:20 +0000 (UTC) X-HE-Tag: men86_390c5d3270de X-Filterd-Recvd-Size: 3105 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Sep 2020 16:09:19 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id cv8so1772395qvb.12 for ; Wed, 09 Sep 2020 09:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XOUyPTsa2Cy1aBInD+QuWOlrkZOb1oPn3ygyN5HSAlw=; b=LoZsiyRN6z3nQTE+reJEuHSLJx/sEAeC0/lg9Ji/pYlB7dC9jGShyT3icZv0Jh+YaM EYDrMJiztU1bZr5xo1De0LQt8sutI/Gr9qQ7/n2Dj9y6PqFSdYF6U94Rg9WYCPglKd1d 0XX9IN2kGMxwHWlJICG360S5k88hyLU+4KSmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XOUyPTsa2Cy1aBInD+QuWOlrkZOb1oPn3ygyN5HSAlw=; b=XNf1oLpRa3TMD1xCjySsn9TrNZsQsxp9Tbva1qvXJDdeKF+KW6qnmzTJkCHK2vTfs7 yn0wgSXBQDHVTxBI8N93f8xf1HYYvVHuiFWmlkVgos99PHUfLYG9nHbPYFBaZ/MiMeaf i+75HvM1kJJ9wo9ZI8rUzx+rlByVgKMD5da1CIAm3aiE6mPG6gXkT/3GPrlTMfAHTbjU EM2gZWyoNxWAR59blcQgWaDlzu0IY0MObJeAzgtAM3LrU3Fm6h/2PWoL6/jEjRhXByre LPdlzNPhsZqPsiGXF0cMzPS6E74/ibes5Pd30alCNrcNvEHiVJOehxOkcbwSEl24gzvL yjFA== X-Gm-Message-State: AOAM530YKoDgO+lSUq1UThMAHq6UH+yp9qNnfPnJkLb7j5VEbOs6FCom olcyYeLuPqwRrN3mWPOce0zA8w== X-Google-Smtp-Source: ABdhPJyL7+T9zIVmdMwKB1/q+iv+QjLVbUi6SxoPu8hTWkv8uve1cnVGV+9GR+PjfuPGIhHSCec3Ng== X-Received: by 2002:a0c:b35d:: with SMTP id a29mr4590496qvf.19.1599667759190; Wed, 09 Sep 2020 09:09:19 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:16fd]) by smtp.gmail.com with ESMTPSA id q3sm2817689qkq.132.2020.09.09.09.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 09:09:18 -0700 (PDT) Date: Wed, 9 Sep 2020 17:09:17 +0100 From: Chris Down To: zangchunxin@bytedance.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH v2] mm/vmscan: fix infinite loop in drop_slab_node Message-ID: <20200909160917.GA1569471@chrisdown.name> References: <20200909152047.27905-1-zangchunxin@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200909152047.27905-1-zangchunxin@bytedance.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Rspamd-Queue-Id: 7CA8D100ED585 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks! This looks reasonable to me, and avoids hard-to-reason-about changes in the existing semantics. zangchunxin@bytedance.com writes: >Signed-off-by: Chunxin Zang >Signed-off-by: Muchun Song Acked-by: Chris Down