From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90BEEC433E2 for ; Wed, 9 Sep 2020 13:14:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17C2121D7D for ; Wed, 9 Sep 2020 13:14:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="gUgD1fzU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17C2121D7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B9F46B005C; Wed, 9 Sep 2020 09:14:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36B026B005D; Wed, 9 Sep 2020 09:14:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 259276B0062; Wed, 9 Sep 2020 09:14:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 104936B005C for ; Wed, 9 Sep 2020 09:14:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B7A1F246E for ; Wed, 9 Sep 2020 13:14:52 +0000 (UTC) X-FDA: 77243568024.04.box01_620da19270dd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 80C4D800BE7F for ; Wed, 9 Sep 2020 13:14:52 +0000 (UTC) X-HE-Tag: box01_620da19270dd X-Filterd-Recvd-Size: 4218 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Sep 2020 13:14:51 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id g72so2311531qke.8 for ; Wed, 09 Sep 2020 06:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lSKQ2gBs091A6cYwdzunzjniesYa3PzG6oul/XWeZkE=; b=gUgD1fzUdMJkYbrbBnLLLRaO1hLlP/RZzQ52A4vdBoE3gv6lbt2GQ/lCAUgJYrLVuD sZpjud3crykrLs2dP89K6cx9KkJSu79+TSLtAvI/75QZSQ5ntoR07ccC/STN462hPIfP fi442MswifED3PyMWn+8NG7EzLEgnGL0iMlDViXlGyj+AcBwOFryTvXeVs9/y3Le6gZ8 snGUn51PbjD3qhU6rWPh3gTwqdsemNM8leXAVVP3OkkNrzPhldzMiZgkFKo96hu9HnFm 5kbw2hMOKg7OkqDYhwVSTrnyUG7/rNo6C9DCgvw9Gp/ZGoKrPGw+W9/Sd8xXCPuOddHJ vaKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lSKQ2gBs091A6cYwdzunzjniesYa3PzG6oul/XWeZkE=; b=IgYxSosbubH0kt2o1uaw/wizjvvKw+mZnxNhliK4FmvZJYS6p3rDSCrMt5jJCYLOOW KREThNsr3vjpIN4+vfCv7eaFy+QpuWIFTPLkcWt9X9xBm3gagMtdIAh4FUCMaf3PYa1S R/FQt4EJFAH5Wg8U4KLrPm4owcGWYdMI/Kq1CVGO/N6f+frckep9QQEq1jcNasg6c6aR ZsIV4Yi+RhPiOfVTtEYS7XMyYlXR20lDQTr847S14h7RRNTGL0+anBVT5vmlpfn5G2ET HabUCnZJBXq7EcM7e5HxdUDVtKB0V2SPMQicIKiGAZm/Et9XkE1Fascn6beEaHUZr+/H /Bvw== X-Gm-Message-State: AOAM531DcGnhqFjYbGHIUeMcRsucZ3rfGM3KwJI6rLmFai/BvLQ9bROr kkLLVFIV8PE5wsLoWKyNwIUNYg== X-Google-Smtp-Source: ABdhPJxAUUa+jSBRbu5cRfiK03kinzrn6jruB7OWvltBz6wW6x0j2Fh1XWhUdsUqw5hQjG7vYx4D+A== X-Received: by 2002:a37:6f05:: with SMTP id k5mr3306129qkc.408.1599657291331; Wed, 09 Sep 2020 06:14:51 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id g203sm2616681qkb.51.2020.09.09.06.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 06:14:50 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kFzw1-003Jih-Rw; Wed, 09 Sep 2020 10:14:49 -0300 Date: Wed, 9 Sep 2020 10:14:49 -0300 From: Jason Gunthorpe To: Matthew Wilcox Cc: Zi Yan , David Hildenbrand , Roman Gushchin , "Kirill A. Shutemov" , linux-mm@kvack.org, Rik van Riel , "Kirill A . Shutemov" , Shakeel Butt , Yang Shi , David Nellans , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/16] 1GB THP support on x86_64 Message-ID: <20200909131449.GF87483@ziepe.ca> References: <20200902180628.4052244-1-zi.yan@sent.com> <20200903142300.bjq2um5y5nwocvar@box> <20200903163020.GG60440@carbon.dhcp.thefacebook.com> <8e677ead-206d-08dd-d73e-569bd3803e3b@redhat.com> <7E20392E-5ED7-4C22-9555-F3BAABF3CBE9@nvidia.com> <20200908142758.GF27537@casper.infradead.org> <20200909121117.GD87483@ziepe.ca> <20200909123244.GD6583@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200909123244.GD6583@casper.infradead.org> X-Rspamd-Queue-Id: 80C4D800BE7F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 09, 2020 at 01:32:44PM +0100, Matthew Wilcox wrote: > But here's the thing ... we already allow > mmap(MAP_POPULATE | MAP_HUGETLB | MAP_HUGE_1GB) > > So if we're not doing THP, what's the point of this thread? I wondered that too.. > An madvise flag is a different beast; that's just letting the kernel > know what the app thinks its behaviour will be. The kernel can pay But madvise is too late, the VMA already has an address, if it is not 1G aligned it cannot be 1G THP already. Jason