From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CA0C43461 for ; Tue, 8 Sep 2020 09:06:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D22AC2166E for ; Tue, 8 Sep 2020 09:06:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=necglobal.onmicrosoft.com header.i=@necglobal.onmicrosoft.com header.b="tP1aUgZ6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D22AC2166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nec.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 21C166B0055; Tue, 8 Sep 2020 05:06:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 180C56B005A; Tue, 8 Sep 2020 05:06:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01F346B005C; Tue, 8 Sep 2020 05:06:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id D7DF46B0055 for ; Tue, 8 Sep 2020 05:06:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8B86F8248047 for ; Tue, 8 Sep 2020 09:06:01 +0000 (UTC) X-FDA: 77239312122.30.bun62_5317801270d3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 67A18180B3C8E for ; Tue, 8 Sep 2020 09:06:01 +0000 (UTC) X-HE-Tag: bun62_5317801270d3 X-Filterd-Recvd-Size: 7547 Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-eopbgr1400083.outbound.protection.outlook.com [40.107.140.83]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Sep 2020 09:06:00 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTDjYWVFUSosievh01ot4pOr+sIu1ZMHspytkt1ReKOemQaQsXP0akrrLOxT1u5QZ/sls4sdJBWQVT+ivCQSl078sHAo3lyettxS9QtrWwyjUjm0M7S0RyTrOdXnXN8SUyrT5iecCSOmkoq+DZY1Y9XsJT9D0szFEpfVltnEe4RScVeZOPGVA5n7J0YryQMUbFP9oub1zzDcBUNsEZA8vtMwQDCL7Z8zxC2xz+o1GEbohT5pzidcbqFomMNDqkRwn0Ekq9EmdU8L9hLE0tDhpXBT5LGGpSgEENZou/JfcDsWgMNrzvjQnMVgJTyNu6mZhd4o/exrAIN/uEFSbcDIYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7Bk80IEmmleqf0xcVJHSFdMsnomX1Nv0Hkrkb7/uuA=; b=i2Qx7OFkcLYxYdA6Mm7iNkjiaYm9xBpMA8Tz6uueHzgfRd6SPYtyDKqo+uyEzxUKnWVk88s5VniiO/X4h8I+PQTdBUP4VII0FhgFvBjJ5OcUP1x0yHfp8ebM3Vy8JV+oBlDetzubpDhJi0IO/vtdX5UFi0dryhd5YIF3orRlDmXAWHTG7BCLY6LAFjeqc2Hdy/z+Z5FGs9StvOqIkVFQkWqCUSbkuvm73vAkYFkfkFAq9jWJ1ebdJRyvXdSb91r1U/dCL6TCKwbuTOFZ7aAQqqUPSEilMMjy1dy1pyyiROMFBzj43Q9YuKRAB+cbkX7afrwc6ALyUODeaCe7/P4lsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nec.com; dmarc=pass action=none header.from=nec.com; dkim=pass header.d=nec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=necglobal.onmicrosoft.com; s=selector1-necglobal-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7Bk80IEmmleqf0xcVJHSFdMsnomX1Nv0Hkrkb7/uuA=; b=tP1aUgZ6ZOcanuU1lgSoH1EbrDF2QsqthyCPYevdESAGNhXFD3650spYqhBAvtxv7/XbKo61ZJNwDzngeA4VwLbV0lwB7xFFN9D/LEVjOwOdFgrfz3ridNJa1c5YIjdxmcEvnJZCSVRzxrKXo4y/vaozxZfHzz0HoX86ipy/uxY= Received: from TY2PR01MB3210.jpnprd01.prod.outlook.com (2603:1096:404:74::14) by TYAPR01MB2511.jpnprd01.prod.outlook.com (2603:1096:404:90::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Tue, 8 Sep 2020 09:05:57 +0000 Received: from TY2PR01MB3210.jpnprd01.prod.outlook.com ([fe80::108f:629c:d934:9206]) by TY2PR01MB3210.jpnprd01.prod.outlook.com ([fe80::108f:629c:d934:9206%7]) with mapi id 15.20.3348.019; Tue, 8 Sep 2020 09:05:56 +0000 From: =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= To: Oscar Salvador CC: "yaoaili126@163.com" , "linux-mm@kvack.org" , "YANGFENG1@kingsoft.com" , Aili Yao , "willy@infradead.org" Subject: Re: [PATCH] Fix incorrect compound page flags store Thread-Topic: [PATCH] Fix incorrect compound page flags store Thread-Index: AQHWhZJ3Og4wKg0ujkGkwEipfrByRaleUMwAgAAGuICAABOjAIAABFGAgAAD54A= Date: Tue, 8 Sep 2020 09:05:56 +0000 Message-ID: <20200908090555.GA17382@hori.linux.bs1.fc.nec.co.jp> References: <20200908034441.16359-1-yaoaili126@163.com> <20200908070210.GA14393@hori.linux.bs1.fc.nec.co.jp> <20200908072603.GA11245@linux> <20200908083630.GA15481@hori.linux.bs1.fc.nec.co.jp> <20200908085153.GA12690@linux> In-Reply-To: <20200908085153.GA12690@linux> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=nec.com; x-originating-ip: [165.225.110.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fc6e6b1-619e-4060-944b-08d853d66593 x-ms-traffictypediagnostic: TYAPR01MB2511: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LEZDyKZ3tyy0vwgPbgoaBCFAADNYUu3BeLpSHeU5OwYHZKnDipyE2ycHDajTjzAASoFbLAF16ywMobb6JXCXkG+Y1P6TctEmAabUUxc+7ONUdL3Votw1K6xdBAZ+tlqnw03vO1KeK7PgGdBf9GlbXiyS2C3QMhRErjrt+aPOumHaceOBV4x8MvJqrKb9sgxCNiMuHpSPhlwk99RAwV/0PQtU48EJC5nQz1E8lhjEK6p6pkmvx4rOzsXLex29AsYPTiw15UbCGCwL+5gXMDw9EYVhv/CGULYV72SFGb1gJpYteAbWB8CXLBP8+JWS96ve x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3210.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(4326008)(186003)(33656002)(26005)(2906002)(55236004)(6506007)(1076003)(9686003)(6512007)(4744005)(316002)(54906003)(66446008)(5660300002)(64756008)(83380400001)(76116006)(478600001)(8936002)(66946007)(86362001)(6486002)(85182001)(6916009)(66476007)(66556008)(71200400001)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 0Bk4qXrCnPl0fsexXopkkTZ7g3vNRNipNDRr7sXq8sGUk8uqkjuizNOI1/8dnWt0vXwWMm26BCGnQL28sGIJr41GUEiLO21805BS9SqSNM4ba+1HLuFBjqImj90kJXMUZs1bnFTVUdq7bcnxZQ7+J2SMuZxfmBIVZ+r/bwnVnCJsHNCFRbS0Gg7hnRSGn8zHaN6Tk4wsi9fZHQ3tLrpINp2D/iQlNiMbcp1S4PBm9Qve6XcPY9x7pn5z8WnAMPRrSkvdf0yaq1evxqIY1a0m+5r4lHYcGKDqplZfKx1xdrwCJqg7mHd6608XBjt0I5f4aJqA1tLp9ZWebTRHH7+oKapLBN7g99p1vo9Rg7Bd8V3zBc0P6Lo1c3TiMtiJm3XN9vpau5FoiLewsUOyScus89ZDuOFgxyWAZpl3W19Glbtkh4UykesyYZe2/JxhD2b7CSlQn//nSMKqFwwYc+rAKOhriNGKxXawGnuxxt6sj3mpJt1wYFaL0AnxwMW6X1MVRwLEFbreuz5lgimayLGTM+JAsZ6KL20vrBIDGHnESj8yaghv9XhYukpuNPYzoVJJ0bumRbZnokRU6ApNMHFiEFl5Yhm+gqUMvyvnl41N6IGyTnEIVk1VKDNr/IovQ3K9ab8WiiDGE4fxDKLyH47fMw== Content-Type: text/plain; charset="iso-2022-jp" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3210.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc6e6b1-619e-4060-944b-08d853d66593 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 09:05:56.2094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I0P0THI9kdevYD2b7fZVFROAVwOr9XMiwleEaUEwhfZmBGEAej0ksux9n6AthhqrHU+tUEFJWtnnTx0o7hUGfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB2511 X-Rspamd-Queue-Id: 67A18180B3C8E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.036514, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 08, 2020 at 10:51:57AM +0200, Oscar Salvador wrote: > On Tue, Sep 08, 2020 at 08:36:32AM +0000, HORIGUCHI NAOYA(=1B$BKY8}=1B(B = =1B$BD>Li=1B(B) wrote: > >=20 > > Theoretically, it could happen that a error could be collapsed into a n= ew > I guess you meant page here? ^^^^ Right, sorry for my typo ... > > thp just after passing over the following block: >=20 >=20 >=20 > >=20 > > 1408 if (PageTransHuge(hpage)) { > > 1409 if (try_to_split_thp_page(p, "Memory Failure") = < 0) { > > 1410 action_result(pfn, MF_MSG_UNSPLIT_THP, = MF_IGNORED); > > 1411 return -EBUSY; > > 1412 } > > 1413 VM_BUG_ON_PAGE(!page_count(p), p); > > 1414 } > >=20 > > So I feel that some check might be added after holding page lock to avo= id > > that case. Or acutally, it might better that moving the above block int= o > > page lock is more better for simpler code. >=20 > I will have a look at this. Thank you!=