From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E44FC433E2 for ; Tue, 8 Sep 2020 08:36:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7058921741 for ; Tue, 8 Sep 2020 08:36:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=necglobal.onmicrosoft.com header.i=@necglobal.onmicrosoft.com header.b="NLQF73L5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7058921741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nec.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B1EDE6B0002; Tue, 8 Sep 2020 04:36:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA7966B0037; Tue, 8 Sep 2020 04:36:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 948116B0055; Tue, 8 Sep 2020 04:36:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 7A96E6B0002 for ; Tue, 8 Sep 2020 04:36:37 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 42A4E181AC9CB for ; Tue, 8 Sep 2020 08:36:37 +0000 (UTC) X-FDA: 77239238034.30.low91_55121e6270d3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 29159180B3AA7 for ; Tue, 8 Sep 2020 08:36:37 +0000 (UTC) X-HE-Tag: low91_55121e6270d3 X-Filterd-Recvd-Size: 8633 Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-eopbgr1400041.outbound.protection.outlook.com [40.107.140.41]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Sep 2020 08:36:36 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AbWstxenBlTBFPK9XXH4Gfo41GooISpSMO2GPpXu0utZqii1wH/b/ynf1kJil87iAn0vUAIGywmTMnZGcm8Dqy0LCQaF1/87nndC2QWz4gLPctTvRShsOv8gTzVfLn1CsnpLg6mhdavqNY28jwAu4kcEiPgBXP82Fy6zPaeTRm701xJHwEN38EdFZ3PtmRHXev8ylgxMEiCPcH+tUS0AkWfNC//8Dv/a1acTZVSnQqFlKrdzmGRFYRlcGm0DGW6/cYB/beSNepaZt4kpDTUko7roFZvnxBmKpcw7QQA8AaidgW206gq3rbfkvZbo/odg+vTsVoywcgOB2CML2lRelQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQ/iNbaZSGVOxv+uchldLADT5ajzko8kC+H8nZfznzQ=; b=Rc2gOpCe9MkgdUAihZcQ1fMeWKC24JxbzI+Qtw/d1hKJX/oTgr8qmRFKiKiiKY9jZyfBBHRov3hfLswdWSXeYOpIvXSCq6COnXRDhzEsmr0VE1MYEJhp4x/HVQclzwaCUF3z47s+4B/WMMQWeNYWV+qwMhvKBo/jx2vSMY521QRC2Pa9dN8D1qQNnhoq+wyN377JxgnxF0WWar5yX45+o6T7WSY71Ovn2GBm+bKvIptmElH2AN0nbg2+XcQioZZG+GdQWVCTfxvTOCNtxABIN07ryDxHEDw7uAFcJcux4qbkXMtZPnY/eu5/IVKaauJFsJbsYqlfFb8ShJodNbLtlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nec.com; dmarc=pass action=none header.from=nec.com; dkim=pass header.d=nec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=necglobal.onmicrosoft.com; s=selector1-necglobal-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQ/iNbaZSGVOxv+uchldLADT5ajzko8kC+H8nZfznzQ=; b=NLQF73L57lcSsJZQ8UGaVgzfJLMISq6TYXyx7X5b+mjbS7rt+f9hGM1BlSGazWHeJS3zJI2/FCXKwbp9jEEO0ywn8PCpOEpXEOH/4eAZBwPKo3wAfB3py126dC++zU2AvkjSuHLf/xpak03i7NXu/f2wJr4T69QtCadEcJmRTlM= Received: from TY2PR01MB3210.jpnprd01.prod.outlook.com (2603:1096:404:74::14) by TY1PR01MB1820.jpnprd01.prod.outlook.com (2603:1096:403:8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.17; Tue, 8 Sep 2020 08:36:32 +0000 Received: from TY2PR01MB3210.jpnprd01.prod.outlook.com ([fe80::108f:629c:d934:9206]) by TY2PR01MB3210.jpnprd01.prod.outlook.com ([fe80::108f:629c:d934:9206%7]) with mapi id 15.20.3348.019; Tue, 8 Sep 2020 08:36:32 +0000 From: =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= To: Oscar Salvador CC: "yaoaili126@163.com" , "linux-mm@kvack.org" , "YANGFENG1@kingsoft.com" , Aili Yao , "willy@infradead.org" Subject: Re: [PATCH] Fix incorrect compound page flags store Thread-Topic: [PATCH] Fix incorrect compound page flags store Thread-Index: AQHWhZJ3Og4wKg0ujkGkwEipfrByRaleUMwAgAAGuICAABOjAA== Date: Tue, 8 Sep 2020 08:36:32 +0000 Message-ID: <20200908083630.GA15481@hori.linux.bs1.fc.nec.co.jp> References: <20200908034441.16359-1-yaoaili126@163.com> <20200908070210.GA14393@hori.linux.bs1.fc.nec.co.jp> <20200908072603.GA11245@linux> In-Reply-To: <20200908072603.GA11245@linux> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=nec.com; x-originating-ip: [165.225.110.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f6d23ed-aabc-4608-ac51-08d853d24a11 x-ms-traffictypediagnostic: TY1PR01MB1820: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3s4PY3oV/Rn5lo360I2lfqJfYPTXWXkiyBwkSyiG6jliIgMZuOuPKKYSZSWzFITptaoGOnYeYNWrhgOfZbSnyzDBSqpnU43MUV4UaNn3SBhewX9FdC9E8HQ6UnRa0y0STj73I735N8bYa222vaOq0sTkqqNAOf0hjQInZg5x53HgTGijv+LB8k52ehQF1ORp0bvRQzutbaxIpBlJXDUU2R9unbvmGQqq3oeYj7VAN7GG22YfB576vFgdbAbFS+IT0CnW2MWOc4uRen3m6BxNG/UzWYUpTpjLA8Y5DRqNO8jeZdUQjjKxWyF1PLX/0yK8LdH/IpaKP87KaSAPWEwbZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3210.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(8936002)(83380400001)(26005)(1076003)(86362001)(71200400001)(6486002)(85182001)(6916009)(55236004)(33656002)(478600001)(8676002)(54906003)(316002)(186003)(4326008)(6506007)(66946007)(76116006)(6512007)(66556008)(66446008)(66476007)(9686003)(64756008)(5660300002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: yl8KJfXfOdlze9IVfHTnSSpcIv2iz7Z0RQWW3Uuh2ZgxMyK9IfhPnt7Oxf/EA1YmduoVPSZ3UH7OFJuIcAS+5J/KRLEcCp1daBmHXKY4EW4KxFtgxxrFWA2U2QhFp6ldjx9a/XLmxN3ZUvkohSrDRjepVuWipQXjmaEVgfObJmH+VLcQTEVSyBqVDo2hXfqTSCrxxzfAtzaXS3rGOLsFKu7/gecul+KtRvARXBPjoZtaGxMhAF7mhXk0FGkdzI+79ZZ7aTy/7lJENeEVkfv9e/9MgqLnDz1klgtoY3u/uTitnA73kRhVD4g4iuuX8gAbv1XPYD5EYNnHT62hbhtcWjXTSU89m6lzmM2/TnZsZWEznwUSZJERoHQlqCEb2mQ+r8iBCEEdcwQkGKJcDUsCwJNLT2FnFu3R7dP965adJdIgWRfmAf5pzGrWgSefy++K6jftA/gcPtjD4bdz0CCHKAYI8k+xk5KVgK+mwPhD5ZPUO/sDXOzID3A1pS/Dbr5/jO1+38HJmtmjotdYHjrQdU7qX3GRIAVxNXgUkl+SndROk6n/rIAiaIGHOaN6rC7iJPWw3buW5zJnW0WyOKlGz2FFx5KqteH+HJKQMjH9rJPtHL11XlOt9qAefkgccDhnyiXTlPg3uYsrFfqvFhgTrw== Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <5AD5F69FB60CAE45B01C8FC3726ADFEF@jpnprd01.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3210.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6d23ed-aabc-4608-ac51-08d853d24a11 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 08:36:32.3055 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zhKXmaxa7jDTltTXt4h/0wthZ/d49LunKj/VR4vVQYfiGRRegjo7XVCad7SCdKLBkW79c2axO3ZbGQDTO6WKQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1820 X-Rspamd-Queue-Id: 29159180B3AA7 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 08, 2020 at 09:26:13AM +0200, Oscar Salvador wrote: > On Tue, Sep 08, 2020 at 07:02:12AM +0000, HORIGUCHI NAOYA(=1B$BKY8}=1B(B = =1B$BD>Li=1B(B) wrote: > > On Mon, Sep 07, 2020 at 08:44:42PM -0700, yaoaili126@163.com wrote: > > > From: Aili Yao > > > > > > PageHuge(p) branch will never be true,but for compound page we need t= o set page_flags to correct value. > > > > > > Reviewed-by: Matthew Wilcox (Oracle) > > > Signed-off-by: Yang Feng < yangfeng1@kingsoft.com> > > > Signed-off-by: Aili Yao > > > > I found that this PageHuge() check is removed and no long exists > > in the latest mmotm, so we don't have worry about it. > > I might be missing something, so bear with me. > > It is true that the PageHuge check is gone, but we are storing the page's > flags in page_flags, even if the page is a tail (e.g: part of a compound = page > ). > Should not we store heads' flags instead? I think that saving ->flags of the raw error page is OK, because even in th= p case we focus on the raw page instead of its head page from memory error perspective. It's not assumed that we can contain the error thp in the thp unit and instead we always rely on thp split. (For hugetlb, we now contain the errored hugetlb in hugetlb unit, so saving its head page might be OK.) Theoretically, it could happen that a error could be collapsed into a new thp just after passing over the following block: 1408 if (PageTransHuge(hpage)) { 1409 if (try_to_split_thp_page(p, "Memory Failure") < 0)= { 1410 action_result(pfn, MF_MSG_UNSPLIT_THP, MF_I= GNORED); 1411 return -EBUSY; 1412 } 1413 VM_BUG_ON_PAGE(!page_count(p), p); 1414 } So I feel that some check might be added after holding page lock to avoid that case. Or acutally, it might better that moving the above block into page lock is more better for simpler code. Thanks, Naoya Horiguchi > AFAICS, hpage contains either the head of the compound page, > or the page itself in case it is a normal page. > > -- > Oscar Salvador > SUSE L3 >=