From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBB2C433E2 for ; Tue, 8 Sep 2020 07:02:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B1D3F2192A for ; Tue, 8 Sep 2020 07:02:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=necglobal.onmicrosoft.com header.i=@necglobal.onmicrosoft.com header.b="Qb5vHpQa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1D3F2192A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nec.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07D068E0001; Tue, 8 Sep 2020 03:02:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02C8F6B005A; Tue, 8 Sep 2020 03:02:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68778E0001; Tue, 8 Sep 2020 03:02:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id D178A6B0055 for ; Tue, 8 Sep 2020 03:02:17 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9E36A181AEF07 for ; Tue, 8 Sep 2020 07:02:17 +0000 (UTC) X-FDA: 77239000314.27.join53_230d32d270d2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 76A6D3D668 for ; Tue, 8 Sep 2020 07:02:17 +0000 (UTC) X-HE-Tag: join53_230d32d270d2 X-Filterd-Recvd-Size: 7481 Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-eopbgr1320045.outbound.protection.outlook.com [40.107.132.45]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Sep 2020 07:02:16 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFtWgFQGcegVVvqrIKTfC1slv+7cHfQHhxxsyrMOlPTUL6QmHPs83X0xrn0BIwGHePCPdKO5UcniatQW/g6MKc3+x/zbUe1fxLE3NtrvNNydHKaNxCFN0vnIKkxuTTzyQ6EjAfYRBjxRGI6PQR/ocb9/x8SAlZeWNSsqm56/9f4xNcZEd+8qiXNPlCsjeuq6tPT2vdwJzQd3pTT+MzhjLiDxmEceX75YwNuPpyukOtUQrKc5dH7wwdXFuQEOSUUTIT1zz9c/Zt/dqGCJzWdk7xE4NIVeeN90zXZOivdagnwMQi7yefoouk5q2XmXXxpA8+5H30x2rWvnrOdHTHYLDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g7+o67vtXiU6ZQ7l9j0IEU6QCaBvvekQJOqhb4//LvI=; b=feJFX3xNiuN/BTUOm/3KOH+Yg2xsLyiTewfgdMfrz0mV5dViDIPJ38qFuUhVxo83b49eCi0b3Y0KourW1lqKDqx+hG1c5AiH5iSIvMwHkJTYK3LRd6Dv4vD8RZoq4Hy+rbkUK2Phx51ElEwv9I85tKplT5TWvrdgCutroUOrpJ53Xxyy8i+qiwOx30zd8kk0P0im3Fa7Jm+2Xh2GSDqajF29/8Eo5ysBK8K/+BYr3yc3U0aG2xdeZoSIyrdO4GqSUHGL9DEXp4og92fj7kKSibBoRl0lhdzZFm23DtKqFrIX/hhh3wF+OlpazPY6SO9YPdNOe3WAXYvZ8GayNYbJ2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nec.com; dmarc=pass action=none header.from=nec.com; dkim=pass header.d=nec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=necglobal.onmicrosoft.com; s=selector1-necglobal-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g7+o67vtXiU6ZQ7l9j0IEU6QCaBvvekQJOqhb4//LvI=; b=Qb5vHpQaZWK6YLn4f+byDC/RKzzPBEYCxpGeVwzDN2FIS0Asm/vQl7VbPQFQyoOIE1sgBg9445q2s8aHamqvOJnX2+EjX3lDXsle4ZUuZoZ64fVCtv1XIouMlNmm9Qx7XtEnzRhzljAm4WXOSkSLH7D0JnsFKuJarS7k7vSySWU= Received: from TY2PR01MB3210.jpnprd01.prod.outlook.com (2603:1096:404:74::14) by TY2PR01MB2988.jpnprd01.prod.outlook.com (2603:1096:404:7a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Tue, 8 Sep 2020 07:02:12 +0000 Received: from TY2PR01MB3210.jpnprd01.prod.outlook.com ([fe80::108f:629c:d934:9206]) by TY2PR01MB3210.jpnprd01.prod.outlook.com ([fe80::108f:629c:d934:9206%7]) with mapi id 15.20.3348.019; Tue, 8 Sep 2020 07:02:12 +0000 From: =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= To: "yaoaili126@163.com" CC: "linux-mm@kvack.org" , "YANGFENG1@kingsoft.com" , Aili Yao , "willy@infradead.org" Subject: Re: [PATCH] Fix incorrect compound page flags store Thread-Topic: [PATCH] Fix incorrect compound page flags store Thread-Index: AQHWhZJ3Og4wKg0ujkGkwEipfrByRaleUMwA Date: Tue, 8 Sep 2020 07:02:12 +0000 Message-ID: <20200908070210.GA14393@hori.linux.bs1.fc.nec.co.jp> References: <20200908034441.16359-1-yaoaili126@163.com> In-Reply-To: <20200908034441.16359-1-yaoaili126@163.com> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 163.com; dkim=none (message not signed) header.d=none;163.com; dmarc=none action=none header.from=nec.com; x-originating-ip: [165.225.110.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 099523ed-00e5-4909-6854-08d853c51c8b x-ms-traffictypediagnostic: TY2PR01MB2988: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vswlo+lR65KQyOOyqrcB+iVBTaZ8A/BmOJe2p3lFCD6Yw2Hwx2YmH/rMC1QbHcSRe7xLjMEQjLerNxj8vxsRqQLQOxhTKixM7zlwXd9yjhypwSianMw/DDqaZPs51OsMFkXqyamIvj7xuJxr/PsYZkLhjhZC9jJqHHeGl498h3N62ev+qjTXqIsnvQyVYPUqzkuWRzvktC9nnTHl2VDG2RmntiJ5chS+hs83tJKsvDiCg9wCmNdCi6kXhvh3D6wPnMTCTGofLUmhG9M0fTdyOab3PLEoTkKSZi1s/stVnKrqFlFllkHUXy1Sb9NaTtgCu9+rcYvz76QCNHQzbkRQeA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3210.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(39860400002)(346002)(396003)(376002)(1076003)(8936002)(6486002)(4326008)(478600001)(54906003)(6916009)(55236004)(6506007)(26005)(186003)(66446008)(2906002)(6512007)(316002)(9686003)(8676002)(71200400001)(83380400001)(66946007)(76116006)(66556008)(33656002)(86362001)(5660300002)(66476007)(64756008)(85182001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: XhMEq9Denl/kG1ssg+jQWx/jdqJlDlrNugHG/JbGqwPcueKbILxH6tnVFpnh9ImlKCWHkUb2/I07mckSmWu/57kLxK/Gx/f/HNQgmy0N7oEu96meAi1slJw2g1JvemnxPwGchnfZ7ZGxvNpPtBjc6D6keAo+ks3GjuDoUaGLSMcg8vuZMORxVXAYokow9Dc/YdzIpHgLT1/U8ENF1V61v4FnoCq3V6eDdgRlZA45XMzEKAp9bNwn6P/yUT3Wf+cxsy0OgdhkLxrf29EoMsjFwhC5JVDgjjc7uNzAbjzYPFIX6C7TnMY0DIfwlpjsrIUdp9yGjwnrxIc36vpfeibkTgwrZU7Hgj0zbE6m8qUHy++7tv7hwRYKxkTml01XAvVzcFRrUxOhppxq4iLV0J9mwpif7w0oQlMzbSvICEAMTfea82c6DRgBA0y8/K0xUNZAmW2HKj8M51SQ6zvsV4GvESTNZYPXzuWMlV7ihiUITcoKPLOfrx6KNzv0a/7ssfdPIA0Z71y0jNdtw0DJIWrRawT4PtW74D+XtVFfsssBMY7vK/psr6aikHAi7XJfMRnOZ6Zi/h119aTt4K88DE5ulbq6HQjs0F8QwcylUHju8y5Czgh6H+J90b3gEW8TMZC1SlnPZ+Xgn9D97MK04Y+Y0g== Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <6B24421CFF73F441B1D24E80DB91E2F4@jpnprd01.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3210.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 099523ed-00e5-4909-6854-08d853c51c8b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 07:02:12.4206 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dYRJWMV0DQUSHqparZIJTVPrr0qZtDuyHkA5yv6f5WimTkRhczHwor54K2r9umbYPt37kw6zRyVt4NvqnNnwoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB2988 X-Rspamd-Queue-Id: 76A6D3D668 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 07, 2020 at 08:44:42PM -0700, yaoaili126@163.com wrote: > From: Aili Yao >=20 > PageHuge(p) branch will never be true,but for compound page we need to se= t page_flags to correct value. >=20 > Reviewed-by: Matthew Wilcox (Oracle) > Signed-off-by: Yang Feng < yangfeng1@kingsoft.com> > Signed-off-by: Aili Yao I found that this PageHuge() check is removed and no long exists in the latest mmotm, so we don't have worry about it. Sorry for missing it in my previous review. Thanks, Naoya Horiguchi > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index f1aa6433f404..e6995976b11d 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1382,7 +1382,7 @@ int memory_failure(unsigned long pfn, int flags) > * page_remove_rmap() in try_to_unmap_one(). So to determine page statu= s > * correctly, we save a copy of the page flags at this time. > */ > - if (PageHuge(p)) > + if (PageCompound(p)) > page_flags =3D hpage->flags; > else > page_flags =3D p->flags; > --=20 > 2.18.4 >=20 > =