From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2ACC433E2 for ; Mon, 7 Sep 2020 06:46:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 37F3B21556 for ; Mon, 7 Sep 2020 06:46:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37F3B21556 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35E586B0003; Mon, 7 Sep 2020 02:46:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E7006B0037; Mon, 7 Sep 2020 02:46:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D6466B0055; Mon, 7 Sep 2020 02:46:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id F3F626B0003 for ; Mon, 7 Sep 2020 02:46:00 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E3E781EE6 for ; Mon, 7 Sep 2020 06:45:59 +0000 (UTC) X-FDA: 77235330438.11.cake74_3a11049270ca Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id A02ED180F8B80 for ; Mon, 7 Sep 2020 06:45:59 +0000 (UTC) X-HE-Tag: cake74_3a11049270ca X-Filterd-Recvd-Size: 2193 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Sep 2020 06:45:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A8268AA55; Mon, 7 Sep 2020 06:45:58 +0000 (UTC) Date: Mon, 7 Sep 2020 08:45:56 +0200 From: Michal Hocko To: Andrew Morton Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wei Yang , Baoquan He , Pankaj Gupta , Oscar Salvador Subject: Re: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining Message-ID: <20200907064556.GB30144@dhcp22.suse.cz> References: <20200903145844.2ead558f5bc3ef3d5230d30f@linux-foundation.org> <20200904122134.1000bb0bf6bc6baf7f5302a7@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904122134.1000bb0bf6bc6baf7f5302a7@linux-foundation.org> X-Rspamd-Queue-Id: A02ED180F8B80 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 04-09-20 12:21:34, Andrew Morton wrote: > On Fri, 4 Sep 2020 07:47:45 +0200 David Hildenbrand wrote: [...] > @@ -1589,9 +1567,7 @@ int __ref offline_pages(unsigned long st > reason = "failure to dissolve huge pages"; > goto failed_removal_isolated; > } > - /* check again */ > - ret = walk_system_ram_range(start_pfn, end_pfn - start_pfn, > - NULL, check_pages_isolated_cb); > + > /* > * per-cpu pages are drained in start_isolate_page_range, but if > * there are still pages that are not free, make sure that we > @@ -1604,15 +1580,15 @@ int __ref offline_pages(unsigned long st > * because has_unmovable_pages explicitly checks for > * PageBuddy on freed pages on other zones. > */ > + ret = test_pages_isolated(start_pfn, end_pfn, MEMORY_OFFLINE); > if (ret) > drain_all_pages(zone); > } while (ret); Looks ok -- Michal Hocko SUSE Labs