From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3000AC43461 for ; Fri, 4 Sep 2020 23:36:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC7152078E for ; Fri, 4 Sep 2020 23:36:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uAqRgdLM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC7152078E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 745996B0083; Fri, 4 Sep 2020 19:36:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A5B16B0087; Fri, 4 Sep 2020 19:36:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 483BA6B0088; Fri, 4 Sep 2020 19:36:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 338E66B0083 for ; Fri, 4 Sep 2020 19:36:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 01FBA248F for ; Fri, 4 Sep 2020 23:36:21 +0000 (UTC) X-FDA: 77226990162.19.owner08_3800271270b6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id CA5DB1AD1B2 for ; Fri, 4 Sep 2020 23:36:20 +0000 (UTC) X-HE-Tag: owner08_3800271270b6 X-Filterd-Recvd-Size: 2304 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Sep 2020 23:36:20 +0000 (UTC) Received: from localhost.localdomain (c-71-198-47-131.hsd1.ca.comcast.net [71.198.47.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A55C2078E; Fri, 4 Sep 2020 23:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599262579; bh=9T7F3+ZA9+rwxl23x0cEp45CnkCE1T/D6iaqdGZC4Do=; h=Date:From:To:Subject:In-Reply-To:From; b=uAqRgdLMxAWDtQDcR7Zjq/HHdzrmgDOdy2Dlq3wmKVPOQa6y6byzcoBxxlydqF6/L dKGNlpu+TypyAApuj29HSdk+TbluhzKcv+2vhU+NIsurq3sdNCN6X6TVGELfQLcWbe XbORkllEyTUN9p0/ZJWSnwQsSa+5HJouKfT6oGyI= Date: Fri, 04 Sep 2020 16:36:19 -0700 From: Andrew Morton To: akpm@linux-foundation.org, jgg@nvidia.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 19/19] include/linux/log2.h: add missing () around n in roundup_pow_of_two() Message-ID: <20200904233619.zbFSnj4Eh%akpm@linux-foundation.org> In-Reply-To: <20200904163454.4db0e6ce0c4584d2653678a3@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: CA5DB1AD1B2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jason Gunthorpe Subject: include/linux/log2.h: add missing () around n in roundup_pow_of_two() Otherwise gcc generates warnings if the expression is complicated. Link: https://lkml.kernel.org/r/0-v1-8a2697e3c003+41165-log_brackets_jgg@nvidia.com Fixes: 312a0c170945 ("[PATCH] LOG2: Alter roundup_pow_of_two() so that it can use a ilog2() on a constant") Signed-off-by: Jason Gunthorpe Signed-off-by: Andrew Morton --- include/linux/log2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/log2.h~log2-add-missing-around-n-in-roundup_pow_of_two +++ a/include/linux/log2.h @@ -173,7 +173,7 @@ unsigned long __rounddown_pow_of_two(uns #define roundup_pow_of_two(n) \ ( \ __builtin_constant_p(n) ? ( \ - (n == 1) ? 1 : \ + ((n) == 1) ? 1 : \ (1UL << (ilog2((n) - 1) + 1)) \ ) : \ __roundup_pow_of_two(n) \ _