From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A648C433E2 for ; Fri, 4 Sep 2020 09:55:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5D5520722 for ; Fri, 4 Sep 2020 09:55:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5D5520722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 91D676B005A; Fri, 4 Sep 2020 05:55:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CDB16B005C; Fri, 4 Sep 2020 05:55:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E3916B0062; Fri, 4 Sep 2020 05:55:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 6A7D26B005A for ; Fri, 4 Sep 2020 05:55:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3128C180AD801 for ; Fri, 4 Sep 2020 09:55:32 +0000 (UTC) X-FDA: 77224921704.10.moon58_250c55a270b1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 085AF16A0BE for ; Fri, 4 Sep 2020 09:55:32 +0000 (UTC) X-HE-Tag: moon58_250c55a270b1 X-Filterd-Recvd-Size: 1687 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Sep 2020 09:55:31 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id D8B8F9CE; Fri, 4 Sep 2020 11:55:29 +0200 (CEST) Date: Fri, 4 Sep 2020 11:55:28 +0200 From: Joerg Roedel To: Robin Murphy Cc: iommu@lists.linux-foundation.org, linux-mm@kvack.org, Roman Gushchin Subject: Re: [PATCH] iommu/dma: Remove broken huge page handling Message-ID: <20200904095528.GS6714@8bytes.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 085AF16A0BE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.076356, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 03, 2020 at 12:34:04PM +0100, Robin Murphy wrote: > The attempt to handle huge page allocations was originally added since > the comments around stripping __GFP_COMP in other implementations were > nonsensical, and we naively assumed that split_huge_page() could simply > be called equivalently to split_page(). It turns out that this doesn't > actually work correctly, so just get rid of it - there's little point > going to the effort of allocating huge pages if we're only going to > split them anyway. > > Reported-by: Roman Gushchin > Signed-off-by: Robin Murphy > --- > drivers/iommu/dma-iommu.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) Applied, thanks.