From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008BAC433E9 for ; Thu, 3 Sep 2020 18:40:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B70BD208C7 for ; Thu, 3 Sep 2020 18:40:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jul2LE9H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B70BD208C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 33D0A6B0089; Thu, 3 Sep 2020 14:40:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EC4A6B008C; Thu, 3 Sep 2020 14:40:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DC1F900004; Thu, 3 Sep 2020 14:40:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 06BA06B0089 for ; Thu, 3 Sep 2020 14:40:11 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C07453631 for ; Thu, 3 Sep 2020 18:40:10 +0000 (UTC) X-FDA: 77222614980.01.army32_4916d85270ab Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 92FC510048E09 for ; Thu, 3 Sep 2020 18:40:10 +0000 (UTC) X-HE-Tag: army32_4916d85270ab X-Filterd-Recvd-Size: 2784 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Sep 2020 18:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=twNne7EcIveImsxJ/Miw6pH23+YkOBeJ0NWRElVb5Rw=; b=jul2LE9HVKVYuXrYUjFG6nOg3x dMIBnhRWsQKsMAdRvT+Urniak2pCc5qLp41UJ/a7mPgxP18g8DPQEXUd/jS+7JLzBzBpsbvLoCvUj W9fX6g+su6ELqsZUu98o2Ue9pQ4qtiUINDhWT33SJdW7L3F3N0ODcGoSSmwfoGoA37ndMpk6z7Cbn GaNp5FGfcOzo89ArjTc6hZTDO/UllsLzaTaG8X2SHtz6UkGoRPqQc1gV2ckZP/2DUeNXSpF130b4j Dqs+5Jmpo7qYfOzTbBRNIyGQgAVO5ohB+KQtYzIlKi1+ud40iKXzGz8ah0ktOCWafqLB0OrekjUGr nVakNP7w==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDu9G-0004SL-TH; Thu, 03 Sep 2020 18:39:50 +0000 Date: Thu, 3 Sep 2020 19:39:50 +0100 From: Matthew Wilcox To: Souptick Joarder Cc: John Hubbard , Barry Song , Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org, linuxarm@huawei.com, Jan Kara , =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Christoph Hellwig , Dan Williams , Dave Chinner , Jason Gunthorpe , Jonathan Corbet , Michal Hocko , Mike Kravetz , Shuah Khan , Vlastimil Babka Subject: Re: [PATCH] mm/gup: don't permit users to call get_user_pages with FOLL_LONGTERM Message-ID: <20200903183950.GF14765@casper.infradead.org> References: <20200819110100.23504-1-song.bao.hua@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 92FC510048E09 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 03, 2020 at 12:42:44PM +0530, Souptick Joarder wrote: > We can use is_valid_gup_flags() inside -> > get_user_pages_locked(), > get_user_pages_unlocked(), > pin_user_pages_locked() as well. > > Are you planning to add it in future patches ? If you're looking for a new project, adding a foll_t or gup_t or something for the FOLL flags (like we have for gfp_t or vm_fault_t) would be helpful. We're inconsistent with our naming here.