From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7191EC433E2 for ; Thu, 3 Sep 2020 16:55:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 643B720665 for ; Thu, 3 Sep 2020 16:55:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="bEpWIzHe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 643B720665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F1CEB6B0003; Thu, 3 Sep 2020 12:55:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECC846B005A; Thu, 3 Sep 2020 12:55:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE2316B005C; Thu, 3 Sep 2020 12:55:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C6FA76B0003 for ; Thu, 3 Sep 2020 12:55:42 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 81FFF8248076 for ; Thu, 3 Sep 2020 16:55:42 +0000 (UTC) X-FDA: 77222351724.07.crowd85_2412602270ab Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 1B1E71803F9AF for ; Thu, 3 Sep 2020 16:55:39 +0000 (UTC) X-HE-Tag: crowd85_2412602270ab X-Filterd-Recvd-Size: 2428 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Sep 2020 16:55:36 +0000 (UTC) Received: from zn.tnic (p200300ec2f0d7a00e86b50da0ecac743.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:7a00:e86b:50da:eca:c743]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 101CD1EC0472; Thu, 3 Sep 2020 18:55:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1599152135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=OPLKDPg36zeWZWe6d3dsjH2xBLWDSt7X8K+c+Hl/bOU=; b=bEpWIzHe3bAC0D37QeSHaxowNs23STJ3pPgtRincOzsFA4Sq/fSWgvohTrWlv9rTfXQrlr IFANXHaT3iRVchu7ehzARXIQ6f5t+IZvTuOy80HZhleImgEWxWmFQoziOXoQKiywI0nvwc NZHIwazOM0AexBG/Nt2l3KdKvLj0sgM= Date: Thu, 3 Sep 2020 18:55:30 +0200 From: Borislav Petkov To: Tony Luck Cc: Naoya Horiguchi , Andrew Morton , Youquan Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFD PATCH] x86/mce: Make sure to send SIGBUS even after losing the race to poison a page Message-ID: <20200903165530.GE5462@zn.tnic> References: <20200827163205.23096-1-tony.luck@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200827163205.23096-1-tony.luck@intel.com> X-Rspamd-Queue-Id: 1B1E71803F9AF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 09:32:05AM -0700, Tony Luck wrote: > The #MC used to win that race and the page was taken offline and SIGBUS > sent to the task. > > Changes to how Linux processes machine checks now mean that: > a) Linux will offline the page based on the UCNA siganture in the > CMCI handler. Let's see if that logic makes sense: if #MC offlines the page and sends SIGBUS but CMCI only offlines the page, isn't it only logical for the CMCI to *also* send the SIGBUS too, after having offlined the page? I.e., both should do the proper and full recovery action. Just sayin... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette