From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0A0C433E9 for ; Thu, 3 Sep 2020 14:09:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C3C4320578 for ; Thu, 3 Sep 2020 14:09:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="b1QyzfCX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3C4320578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 101476B0071; Thu, 3 Sep 2020 10:08:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6B648E0001; Thu, 3 Sep 2020 10:08:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB6766B0073; Thu, 3 Sep 2020 10:08:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id AE67B6B0071 for ; Thu, 3 Sep 2020 10:08:57 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6AC1B8248076 for ; Thu, 3 Sep 2020 14:08:57 +0000 (UTC) X-FDA: 77221931514.26.force62_3f17a92270aa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 2E5881804B656 for ; Thu, 3 Sep 2020 14:08:57 +0000 (UTC) X-HE-Tag: force62_3f17a92270aa X-Filterd-Recvd-Size: 2970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Sep 2020 14:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=kHj2RN10MLCA+ByH4nC1EoFYnrC6ZhmtON9tQxUs7Hs=; b=b1QyzfCXJDcyCQX3PxWVutkVmd KfitQjqw8gekKGAcE00XNQcepq8fnlYmHpfIO2s7jbd9nxYbO6YTPAeWg/cs1tCChA+cjjir+Mpd0 xSeMtrb7L/xgdfkVyIlZgkHenXGys8apqJhScHGcPYy5PXZdb/HQ3rHVVk2sLRpmbvRpErznteCBA zTqhTpw1um/RIrgndohkDEeghF+gSYluc9zDErBzHWL6zapy1OIbXs5u9wSZCiyEC4QmxKfhISElV ELQpd3tdZM9rjM/czXDnz17pVBhfqonJ8O/e2R7yHJS1CygKUbrwny0J7ZoF7JRqqk6NQfYGDrnMG S4GcGDZw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDpv1-0003hv-Av; Thu, 03 Sep 2020 14:08:51 +0000 From: "Matthew Wilcox (Oracle)" To: Andrew Morton Cc: David Howells , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Eric Biggers , Song Liu , Matthew Wilcox , Yang Shi , Pankaj Gupta Subject: [PATCH 1/9] Fix khugepaged's request size in collapse_file Date: Thu, 3 Sep 2020 15:08:36 +0100 Message-Id: <20200903140844.14194-2-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200903140844.14194-1-willy@infradead.org> References: <20200903140844.14194-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 2E5881804B656 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: David Howells collapse_file() in khugepaged passes PAGE_SIZE as the number of pages to be read to page_cache_sync_readahead(). The intent was probably to read a single page. Fix it to use the number of pages to the end of the window instead. Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) F= S") Signed-off-by: David Howells Acked-by: Song Liu Reviewed-by: Matthew Wilcox (Oracle) Acked-by: Yang Shi Acked-by: Pankaj Gupta --- mm/khugepaged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index e749e568e1ea..cfa0dba5fd3b 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1709,7 +1709,7 @@ static void collapse_file(struct mm_struct *mm, xas_unlock_irq(&xas); page_cache_sync_readahead(mapping, &file->f_ra, file, index, - PAGE_SIZE); + end - index); /* drain pagevecs to help isolate_lru_page() */ lru_add_drain(); page =3D find_lock_page(mapping, index); --=20 2.28.0