From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A66C433E9 for ; Thu, 3 Sep 2020 19:22:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CBE0920BED for ; Thu, 3 Sep 2020 19:22:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IrPwGOqT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBE0920BED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 515436B0074; Thu, 3 Sep 2020 15:22:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C64B6B0075; Thu, 3 Sep 2020 15:22:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B45A6B0078; Thu, 3 Sep 2020 15:22:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 20A486B0074 for ; Thu, 3 Sep 2020 15:22:22 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C54D2181AEF00 for ; Thu, 3 Sep 2020 19:22:21 +0000 (UTC) X-FDA: 77222721282.16.force50_29064a2270ac Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 90774100E690C for ; Thu, 3 Sep 2020 19:22:21 +0000 (UTC) X-HE-Tag: force50_29064a2270ac X-Filterd-Recvd-Size: 1961 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Sep 2020 19:22:21 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15FE4208FE; Thu, 3 Sep 2020 19:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599160940; bh=qrU9WP85gio2U/xOxsjI6OQmaemPSNLwvExZVcQaiJI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IrPwGOqTv/KWNBrt1u4S7EwYUUGRjlpElggScKVY+7W4Ixse0AjqAOzDwaanViz3l h0Wh9hdgoPIDK9ZlLTdqUMzrwfafpurypMlMfvJrYkdIfuynzS1Klva+0zkKp12SRc FuObmMfsMgQHesWMfhIyVMomBTTbEaa4bKwUWGpw= Date: Thu, 3 Sep 2020 12:22:18 -0700 From: Andrew Morton To: "Matthew Wilcox (Oracle)" Cc: David Howells , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Eric Biggers Subject: Re: [PATCH 3/9] mm/readahead: Make page_cache_ra_unbounded take a readahead_control Message-Id: <20200903122218.42bd70d930cba998e3faf32c@linux-foundation.org> In-Reply-To: <20200903140844.14194-4-willy@infradead.org> References: <20200903140844.14194-1-willy@infradead.org> <20200903140844.14194-4-willy@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 90774100E690C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 3 Sep 2020 15:08:38 +0100 "Matthew Wilcox (Oracle)" wrote: > Define it in the callers instead of in page_cache_ra_unbounded(). > The changelogs for patches 2-9 are explaining what the patches do, but not why they do it, Presumably there's some grand scheme in mind, but it isn't being revealed to the reader!