From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD08C433E7 for ; Wed, 2 Sep 2020 11:35:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E11772065E for ; Wed, 2 Sep 2020 11:35:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jwSBE4b8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E11772065E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B4596B0037; Wed, 2 Sep 2020 07:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7650C6B0055; Wed, 2 Sep 2020 07:35:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67B746B005A; Wed, 2 Sep 2020 07:35:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 534E46B0037 for ; Wed, 2 Sep 2020 07:35:21 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0CE30362B for ; Wed, 2 Sep 2020 11:35:21 +0000 (UTC) X-FDA: 77217915642.21.meat18_4b08da1270a0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 671B5180442D0 for ; Wed, 2 Sep 2020 11:35:18 +0000 (UTC) X-HE-Tag: meat18_4b08da1270a0 X-Filterd-Recvd-Size: 2748 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Sep 2020 11:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=m2ryxLSrxF0m/wqxXfT38rvwkvOuAm83p0qW1NiAcSI=; b=jwSBE4b8KT1rWqVUwmcn/bpiiM Wnz3J7zsFZHfR0flg4XWT7Q+sYyIIiUq8mXXkdLGK6lq2zgFxMjwtJgOuR+3EeHgQmrV7LsZuDSci kpddkd9odsMH/rCyL04Gfa/LPjFU3w9R/wVm4j79doHAOHuzjXsz7q/VILqIaDAJTckNNwDW3AFoY RcYpO62HKBmwKmZw+6k0k6iZGGJHCXJuOyHLPISkAucvb7Akr7VcOMw1JQ6KS6UNN+de8uRcdowCl VbVyYt89B9+ZbwGf0TJGaIG9UDC102L2r480tI50cCJ8sK9il5OpEfmUj/MYkfbL23G/zY+gCpGqg mWgEADxA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDR2a-00056u-B9; Wed, 02 Sep 2020 11:35:00 +0000 Date: Wed, 2 Sep 2020 12:35:00 +0100 From: Matthew Wilcox To: yaoaili =?utf-8?B?W+S5iOeIseWIqV0=?= Cc: "naoya.horiguchi@nec.com" , "linux-mm@kvack.org" , YANGFENG1 =?utf-8?B?W+adqOWzsF0=?= Subject: Re: [PATCH] fix incorrect compound page flags store Message-ID: <20200902113500.GW14765@casper.infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 671B5180442D0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 02, 2020 at 11:24:59AM +0000, yaoaili [=E4=B9=88=E7=88=B1=E5=88= =A9] wrote: > PageHuge(p) branch will never be true,but for compound page we need to = set page_flags to correct value. You're missing a Signed-off-by line. Your analysis is correct; PageHuge was tested for a few dozen lines higher, and we ran off to a different function. Ad far as I understand this function, this looks right to me. Reviewed-by: Matthew Wilcox (Oracle) > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index f1aa6433f404..e6995976b11d 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1382,7 +1382,7 @@ int memory_failure(unsigned long pfn, int flags) > * page_remove_rmap() in try_to_unmap_one(). So to determine pa= ge status > * correctly, we save a copy of the page flags at this time. > */ > - if (PageHuge(p)) > + if (PageCompound(p)) > page_flags =3D hpage->flags; > else > page_flags =3D p->flags; > -- > 2.25.1