From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E8FC433E2 for ; Tue, 1 Sep 2020 16:41:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B998B2087D for ; Tue, 1 Sep 2020 16:41:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WvjCz2qB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B998B2087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 59672900012; Tue, 1 Sep 2020 12:41:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51F90900002; Tue, 1 Sep 2020 12:41:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C1C8900012; Tue, 1 Sep 2020 12:41:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 26CCF900002 for ; Tue, 1 Sep 2020 12:41:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DB346180AD806 for ; Tue, 1 Sep 2020 16:41:35 +0000 (UTC) X-FDA: 77215058550.30.shake30_16119b427099 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 41E37180B3C8E for ; Tue, 1 Sep 2020 16:41:35 +0000 (UTC) X-HE-Tag: shake30_16119b427099 X-Filterd-Recvd-Size: 2117 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 16:41:34 +0000 (UTC) Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0E5C20767; Tue, 1 Sep 2020 16:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598978493; bh=Dpj3KMcxE1VLvM7pvNMakfITVTdblxRjjMAZljRkcDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WvjCz2qBgk+FjDtaXrxOLkuzmSpoC4TPO6NJF7n+CDvIMNWJQWf99TvOqppqIMqw8 6AhmQ6HzzYRQSIMUnBHMLF7hekb3DnxI1zqCnflew4pbnq/sR2xUas2XQNIH19JdHZ F9Syn/FXhE0QGH+nz2WFVMtNgTW0oGlziYXvCKB0= Date: Tue, 1 Sep 2020 09:41:32 -0700 From: Eric Biggers To: David Howells Cc: willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/7] mm: Make more use of readahead_control Message-ID: <20200901164132.GD669796@gmail.com> References: <159897769535.405783.17587409235571100774.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159897769535.405783.17587409235571100774.stgit@warthog.procyon.org.uk> X-Rspamd-Queue-Id: 41E37180B3C8E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 01, 2020 at 05:28:15PM +0100, David Howells wrote: > > Hi Willy, > > Here's a set of patches to expand the use of the readahead_control struct, > essentially from do_sync_mmap_readahead() down. Note that I've been > passing the number of pages to read in rac->_nr_pages, and then saving it > and changing it certain points, e.g. page_cache_readahead_unbounded(). > > Also pass file_ra_state into force_page_cache_readahead(). > > Also there's an apparent minor bug in khugepaged.c that I've included a > patch for: page_cache_sync_readahead() looks to be given the wrong size in > collapse_file(). > What branch does this apply to? - Eric