From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18BDC433E2 for ; Tue, 1 Sep 2020 13:55:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A9708207D3 for ; Tue, 1 Sep 2020 13:55:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9708207D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94B34900003; Tue, 1 Sep 2020 09:55:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D266900002; Tue, 1 Sep 2020 09:55:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77757900003; Tue, 1 Sep 2020 09:55:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 59383900002 for ; Tue, 1 Sep 2020 09:55:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0C84A3630 for ; Tue, 1 Sep 2020 13:55:13 +0000 (UTC) X-FDA: 77214639306.04.skate19_17184f127098 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id CDF868007FF3 for ; Tue, 1 Sep 2020 13:55:12 +0000 (UTC) X-HE-Tag: skate19_17184f127098 X-Filterd-Recvd-Size: 2766 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 13:55:12 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kD6kf-0001nf-02; Tue, 01 Sep 2020 15:55:09 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 62CB0C0E4C; Tue, 1 Sep 2020 15:53:04 +0200 (CEST) Date: Tue, 1 Sep 2020 15:53:04 +0200 From: Thomas Bogendoerfer To: Christoph Hellwig Cc: Mauro Carvalho Chehab , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Ben Skeggs , Pawel Osciak , Marek Szyprowski , Matt Porter , iommu@lists.linux-foundation.org, Tom Lendacky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 08/28] MIPS: make dma_sync_*_for_cpu a little less overzealous Message-ID: <20200901135304.GC11944@alpha.franken.de> References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819065555.1802761-9-hch@lst.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-Rspamd-Queue-Id: CDF868007FF3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 19, 2020 at 08:55:35AM +0200, Christoph Hellwig wrote: > When transferring DMA ownership back to the CPU there should never > be any writeback from the cache, as the buffer was owned by the > device until now. Instead it should just be invalidated for the > mapping directions where the device could have written data. > Note that the changes rely on the fact that kmap_atomic is stubbed > out for the !HIGHMEM case to simplify the code a bit. > > Signed-off-by: Christoph Hellwig > --- > arch/mips/mm/dma-noncoherent.c | 44 +++++++++++++++++++++------------- > 1 file changed, 28 insertions(+), 16 deletions(-) Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]